New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect/correct invalid HP/LP settings in EDF/BDF/GDF #8584
Conversation
@apospraf loading files from BCI Competition IV 2B works as expected with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to add a quick test via monkeypatch
(probably of _read_edf_header
)? If not I can see if it's easy and push if so
Please go ahead and add a test, I won't have time until tomorrow. |
I don't think the current approach quite works properly, for example it doesn't handle
Moreover sometimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx @cbrnr
@cbrnr all good now? |
Yes, perfect! |
Fixes #8582. EDF/BDF/GDF files can contain invalid LP/HP filter settings (cutoff frequencies for HP can be greater than the one for LP). This PR (1) issues a warning and (2) sets HP/LP values for affected channels to
None
.