Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, FIX, VIZ: correctly triage extrapolation mask for topos based on channel type #8589

Merged
merged 3 commits into from Dec 1, 2020

Conversation

drammock
Copy link
Member

@drammock drammock commented Dec 1, 2020

failure to pass through ch_type was the culprit; the underlying plotting function thought everything was 'eeg'.

@drammock
Copy link
Member Author

drammock commented Dec 1, 2020

Here's the rendering showing the correct mask:
https://23871-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/epochs/plot_20_visualize_epochs.html#plotting-the-power-spectrum-of-epochs

@drammock drammock changed the title FIX, VIZ: correctly triage extrapolation mask for topos based on channel type MRG, FIX, VIZ: correctly triage extrapolation mask for topos based on channel type Dec 1, 2020
@larsoner larsoner merged commit 2b0f0c5 into mne-tools:master Dec 1, 2020
2 checks passed
@larsoner
Copy link
Member

larsoner commented Dec 1, 2020

Thanks @drammock

@drammock drammock deleted the fix-meg-topo-mask branch December 2, 2020 02:26
@agramfort
Copy link
Member

agramfort commented Dec 2, 2020 via email

@larsoner
Copy link
Member

larsoner commented Dec 2, 2020

I think we're going to release in a couple of weeks, I don't see much point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants