MRG, MAINT: Remove _read_dig_points #8622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
mne.io._digitization._read_dig_points
and_set_dig_kit
in favor ofmne.io.kit.coreg._read_dig_kit
and_set_dig_kit
. The first function just reads files based on names that typically (I'm assuming) come with KIT machines to work the same way as it did before with KIT coreg, etc. The second does transforms necessary to get in the correct coondinate system. This is similar to how things work with CTF, and makes_digitization
cleaner. The_kit
functions now only show up inio/kit
andgui/*kit*
.on_header_missing
toread_polhemus_fastscan
because some of our testing files and such do not produce this header, and it's possible there are files in the wild that the KIT people are using that have this feature.Part of #7591. @christianbrodbeck can you look since this messes with KIT?