Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG, VIZ: fix annotation redraw when changing window duration #8689

Merged
merged 2 commits into from Dec 30, 2020
Merged

MRG, VIZ: fix annotation redraw when changing window duration #8689

merged 2 commits into from Dec 30, 2020

Conversation

drammock
Copy link
Member

closes #8686

cbrnr
cbrnr approved these changes Dec 30, 2020
View reviewed changes
Copy link
Contributor

@cbrnr cbrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed this fixes the issue! Thanks @drammock!

@cbrnr
Copy link
Contributor

cbrnr commented Dec 30, 2020

The only thing missing before this should be merged is a changelog entry.

@drammock drammock changed the title VIZ: fix annotation redraw when changing window duration MRG, VIZ: fix annotation redraw when changing window duration Dec 30, 2020
@cbrnr cbrnr merged commit 303fabe into mne-tools:master Dec 30, 2020
@cbrnr
Copy link
Contributor

cbrnr commented Dec 30, 2020

Thanks @drammock!

drammock added a commit that referenced this pull request Dec 30, 2020
@drammock
MRG, VIZ: fix annotation redraw when changing window duration (#8689)
722d361 
* fix annotation redraw when changing window dur

* changelog entry [ci skip]
@drammock drammock deleted the fix-annotation-redraw branch December 30, 2020 21:17
@larsoner
Copy link
Member

larsoner commented Jan 8, 2021

FYI @drammock looks like you missed the doc/changes/0.22.inc update when backporting, I put it in 133b41f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrnr cbrnr cbrnr approved these changes

Assignees
No one assigned
Labels
backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enlarging time range in raw.plot doesn't draw new annotations
3 participants
@drammock @cbrnr @larsoner