fix: restore build broken by the website redesign#61
Merged
Conversation
The redesign merge (#60) left main failing to compile, which turned CI red and blocked the modelparams npm release (it gates on a clean root typecheck). - Drop a duplicated paramGroupColor import in render.ts - Guard the possibly-undefined entry in the scroll-top observer
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💭 Why
The website redesign merge (#60) left
mainfailing to compile, turning CI red and blocking themodelparamsnpm release (the release gates on a clean root typecheck).✨ What changed
paramGroupColorimport inrender.ts.entryin the scroll-top IntersectionObserver.🔧 For operators
After merge, re-run the "Release modelparams" workflow with
force_level=patchto publish the first package version.