fix: let any Manifest dashboard embed the Wingman drawer#1
Merged
Conversation
frame-ancestors was 'self' https://*.manifest.build, which only covered the cloud dashboard at app.manifest.build. Localhost dev dashboards and any self-hosted Manifest instance got blocked with a "refused to connect" page when opening the drawer. The drawer is a public dev tool with no first-party backend. API keys flow directly from the iframe to whatever baseUrl the user types, and the backend's CORS is the actual gate. A "hostile" embedder can't read anything useful from inside, so frame-ancestors * is the right level.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💭 Why
The dashboard drawer embeds wingman.manifest.build via iframe. CSP
frame-ancestorswas scoped to'self' https://*.manifest.build, so localhost dev dashboards and self-hosted Manifest installs hit a "refused to connect" page when opening the drawer. The only flow that worked was the cloud dashboard atapp.manifest.build.✨ What changed
vercel.json:frame-ancestors 'self' https://*.manifest.build→frame-ancestors *.👤 For users
Drawer now loads from any host. Dev (
http://localhost:*) and self-hosted backends (any domain) can embed Wingman without browser-level refusal.📝 Notes
Wingman is a static SPA with no first-party backend. API keys go directly from the iframe to whatever
baseUrlthe user configures, and that backend's CORS is the actual gate (https://wingman.manifest.buildhas to be in the backend's allow-list). A "hostile" embedder can't read inside the iframe (same-origin policy still applies), so opening up frame-ancestors does not add a useful attack surface.