New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2d fixes #25

Merged
merged 9 commits into from Jan 9, 2012

Conversation

Projects
None yet
3 participants
@harningt
Copy link
Contributor

harningt commented Jan 9, 2012

Many fixes to unit handling (the necessary units for torque were derived both experimentally by testing various scaling factors and taking what "should" be used for torque units (Newton-Meters => kg * m / s^2 * m)

Also changed were unifying motorized joints (added setMotor and setMotorSpeed where needed), and fixing some off-by-one errors in Lua access code.

Let me know if I need to sign the code contribution agreement. I think I'll be contributing a bunch :) Easy to enhance the code.

patrickmeehan added a commit that referenced this pull request Jan 9, 2012

@patrickmeehan patrickmeehan merged commit 9738aa7 into moai:master Jan 9, 2012

@patrickmeehan

This comment has been minimized.

Copy link
Member

patrickmeehan commented Jan 9, 2012

Thanks again for all your help with this. Re the contribution agreement, if it's no trouble for you we do appreciate them.

@mikeatzipline

This comment has been minimized.

Copy link

mikeatzipline commented Jan 9, 2012

Great! Yes, we will need a signed contributor agreement. Looking forward to you contributions.

-Mike

On Jan 8, 2012, at 6:59 PM, "Thomas Harning Jr."reply@reply.github.com wrote:

Many fixes to unit handling (the necessary units for torque were derived both experimentally by testing various scaling factors and taking what "should" be used for torque units (Newton-Meters => kg * m / s^2 * m)

Also changed were unifying motorized joints (added setMotor and setMotorSpeed where needed), and fixing some off-by-one errors in Lua access code.

Let me know if I need to sign the code contribution agreement. I think I'll be contributing a bunch :) Easy to enhance the code.

You can merge this Pull Request by running:

git pull https://github.com/harningt/moai-beta box2d-unit-fixes

Or you can view, comment on it, or merge it online at:

#25

-- Commit Summary --

  • MOAIBox2D: additional Wheel-joint docs & fixes torque unit conversion and updates code documentation
  • MOAIBox2D: unit conversion does not apply to axis inputs
  • MOAIBox2D: fixes off-by-one Lua indexes
  • MOAIBox2DPrismaticJoint: fixes force collection to properly pass in the 'step' value
  • MOAIBox2DRopeJoint: remove debug printf
  • MOAIBox2DRevoluteJoint: clones MOAIBox2DWheelJoint's setMotorSpeed method for completeness
  • MOAIBox2DPrismaticJoint: adds matching setMotorSpeed from other joints w/ similar API
  • MOAIBox2D*Joint: updates setMotor call to optionally force it to be enabled or not (ignoring speed)
  • MOAIBox2DWheelJoint: adds setMotor from MOAIBox2DRevoluteJoint

-- File Changes --

M src/moaicore/MOAIBox2DBody.cpp (7)
M src/moaicore/MOAIBox2DDistanceJoint.cpp (6)
M src/moaicore/MOAIBox2DFrictionJoint.cpp (14)
M src/moaicore/MOAIBox2DGearJoint.cpp (2)
M src/moaicore/MOAIBox2DJoint.cpp (6)
M src/moaicore/MOAIBox2DPrismaticJoint.cpp (38)
M src/moaicore/MOAIBox2DPrismaticJoint.h (1)
M src/moaicore/MOAIBox2DRevoluteJoint.cpp (52)
M src/moaicore/MOAIBox2DRevoluteJoint.h (1)
M src/moaicore/MOAIBox2DRopeJoint.cpp (3)
M src/moaicore/MOAIBox2DWheelJoint.cpp (70)
M src/moaicore/MOAIBox2DWheelJoint.h (1)
M src/moaicore/MOAIBox2DWorld.cpp (21)

-- Patch Links --

https://github.com/moai/moai-beta/pull/25.patch
https://github.com/moai/moai-beta/pull/25.diff


Reply to this email directly or view it on GitHub:
#25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment