New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box2d unit fixes #29

Merged
merged 4 commits into from Mar 28, 2012

Conversation

Projects
None yet
2 participants
@harningt
Copy link
Contributor

harningt commented Feb 26, 2012

More unit fixes collected and updated over time.

I checked against the official Box2D documentation and worked on making sure units were synced up.
Documentation was also updated to help show conversion rules in action.

The commit to update the arbiter may need to be reworked since I wasn't entirely certain on how the arbiter should be linked to the world. Since it appears that there is only 1 arbiter instance created (the Lua 'new' operation is overwritten and the only C++ 'new' construction is performed in creating the world itself).

harningt added some commits Jan 14, 2012

MOAIBox2D: major update to put MOAIBox2D in line w/ Box2D documentati…
…on about units (omitting fix for Box2D Arbiter)
MOAIBox2D: update for MOAIBox2DArbiter to use unit conversion
 - unsure if proper implementation.. might be better suited to
   make MOAIBox2DArbiter a MOAIBox2DPrim since it builds in mWorld
MOAIBox2D: updates accessor for UnitsToMeters to be 'const' so that M…
…OAIBox2DArbiter can take a 'const' world instance
@patrickmeehan

This comment has been minimized.

Copy link
Member

patrickmeehan commented Mar 25, 2012

Thanks! I'll be bringing these over to 1.0 in the coming week. Sorry for the delay!

patrickmeehan added a commit that referenced this pull request Mar 28, 2012

@patrickmeehan patrickmeehan merged commit 0adbf70 into moai:master Mar 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment