Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Apply Modern Standards #60

Merged
merged 12 commits into from Jun 13, 2016
Merged

Apply Modern Standards #60

merged 12 commits into from Jun 13, 2016

Conversation

marlowpayne
Copy link

@marlowpayne marlowpayne commented Mar 25, 2016

Reviewers: @jansepar @fractaltheory @mikenikles @MikeKlemarewski

Changes

Update Bellows to some modern best-practices

  • Prep for publishing to NPM
  • Remove Zepto support in favor of jQuery
  • Migrate all dependencies to NPM, remove Bower
  • Migrate JS linting to eslint
  • Migrate SCSS compilation to libsass
  • Lint SCSS with sass-lint
  • Update circleCI config with modern testing steps
  • Add some GitHub templates for contributing, issues, and PRs

Todos:

  • Add a PR template
  • +1
  • +1 (Major version bump)
  • Update package.json and Readme with a non-conflicting NPM package name

How to Test

  • Checkout code
  • Refresh node modules with rm -rf node_modules && npm install
  • Test with grunt test or grunt test:browser
  • Check that the examples still work with grunt examples
  • Check out this branch of Extra Stores that uses this new code for its Bellows

@jansepar
Copy link
Contributor

💥

@aerykk
Copy link
Contributor

aerykk commented Mar 25, 2016

💥 Tests pass. LGTM 👍

@henryh15
Copy link

henryh15 commented Jun 9, 2016

👍 LGTM! All tests pass.

@marlowpayne marlowpayne merged commit c5f1a09 into develop Jun 13, 2016
@marlowpayne marlowpayne deleted the modern-standards branch June 13, 2016 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

4 participants