wrap attribute setting in try/catch to avoid bailing on terrible markup #107

Merged
merged 4 commits into from Mar 6, 2013

Conversation

2 participants
@noahadams
Owner

noahadams commented Mar 5, 2013

No description provided.

@noahadams

This comment has been minimized.

Show comment Hide comment
@noahadams

noahadams Mar 5, 2013

Owner

test?

Owner

noahadams commented Mar 5, 2013

test?

noahadams added some commits Mar 5, 2013

adds a test for makeElement behaviour, exposes it globally for testin…
…g purposes, this test case would throw in earlier versions
make test less strict, previous behaviour was to throw, so ok() is a …
…sufficient assertion. Old test does not work on simulated iOS 5 or phantomJS
@noahadams

This comment has been minimized.

Show comment Hide comment
@noahadams

noahadams Mar 5, 2013

Owner

test.

Owner

noahadams commented Mar 5, 2013

test.

johnboxall added a commit that referenced this pull request Mar 6, 2013

Merge pull request #107 from mobify/catch-attribute-setting-errors
wrap attribute setting in try/catch to avoid bailing on terrible markup

@johnboxall johnboxall merged commit 7ea4dc1 into master Mar 6, 2013

1 check passed

default
Details

@tedtate tedtate deleted the catch-attribute-setting-errors branch Dec 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment