fixes combo warm cache test by re-ordering cache loading and combineScripts() call #112

Merged
merged 3 commits into from Mar 6, 2013

Conversation

Projects
None yet
2 participants
Owner

noahadams commented Mar 5, 2013

..., it is unclear to me why this has been passing with phantomjs

Owner

b1tr0t commented Mar 6, 2013

@noahadams Was there actually a regression of some kind on warm cache? Or did someone just notice the test was passing and shouldn't have?

b1tr0t merged commit 57c75ef into master Mar 6, 2013

1 check passed

default
Details
Owner

noahadams commented Mar 6, 2013

I noticed that this was consistently failing in chrome, but with good reason (the main thing is the call to combineScripts before the cache had been reset), and that there was a failing request happening as a result (as the fallback for combo execution when the script is not present in its resources dictionary is to write out a script tag referencing the original src).

tedtate deleted the fix-jazzcat-tests branch Dec 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment