New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added iOS8 preload-top-hits issue fix for v7 tag #306

Merged
merged 4 commits into from Sep 24, 2015

Conversation

4 participants
@fractaltheory

fractaltheory commented Jul 27, 2015

Status: Ready for Review
Owner: @donnielrt
Reviewers: @haroldtreen @jansepar

Jira Tickets:

Todos:

  • Don +1
  • Shawn +1
  • Minified version

Feedback:

none so far

Changes

  • Add a workaround in the v7 tag for an iOS8 issue, where the autocomplete request for a site sets a mobify-path cookie to blank
  • Use the page visibility API to detect if we're in a background tab, in which case we don't drop an opt-out cookie

How to Test

  • Use Charles to rewrite to this tag, and verify that the mobify-path cookie isn't being set
@donnielrt

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Jul 29, 2015

Contributor

Thanks for getting this started @fractaltheory, taking a look now.

Contributor

donnielrt commented Jul 29, 2015

Thanks for getting this started @fractaltheory, taking a look now.

Show outdated Hide outdated tag/v7.js
//
// Related ticket: https://mobify.atlassian.net/browse/RTM-280
//
if (doc.visibilityState && doc.hidden) {

This comment has been minimized.

@donnielrt

donnielrt Jul 29, 2015

Contributor

There's no "doc" here :) We need to change this to document

@donnielrt

donnielrt Jul 29, 2015

Contributor

There's no "doc" here :) We need to change this to document

This comment has been minimized.

@fractaltheory
@fractaltheory
@donnielrt

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Jul 29, 2015

Contributor

Confirmed that this fixes the issue for the v7 tag as well, woohoo!

👍

Contributor

donnielrt commented Jul 29, 2015

Confirmed that this fixes the issue for the v7 tag as well, woohoo!

👍

@donnielrt

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Jul 29, 2015

Contributor

@jansepar carrying on the discussion from the v6 tag PR, do you think we need to make this fix opt-out rather than opt-in? I vote yes.

Contributor

donnielrt commented Jul 29, 2015

@jansepar carrying on the discussion from the v6 tag PR, do you think we need to make this fix opt-out rather than opt-in? I vote yes.

@stewartyu

This comment has been minimized.

Show comment
Hide comment
@stewartyu

stewartyu Aug 7, 2015

Is it minified if there are 3 lines? (philosoraptor)

stewartyu commented on tag/v7.min.js in 644c231 Aug 7, 2015

Is it minified if there are 3 lines? (philosoraptor)

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Aug 26, 2015

Contributor

Stew, yeah, I'd run it through GCC, not sure if we can get it much smaller. Is that what you meant?

Contributor

donnielrt replied Aug 26, 2015

Stew, yeah, I'd run it through GCC, not sure if we can get it much smaller. Is that what you meant?

@donnielrt

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Sep 18, 2015

Contributor

@jansepar can I get a hallelujah?

Contributor

donnielrt commented Sep 18, 2015

@jansepar can I get a hallelujah?

@jansepar

This comment has been minimized.

Show comment
Hide comment
@jansepar

jansepar Sep 24, 2015

Contributor

Looks pretty legit! 👍

Contributor

jansepar commented Sep 24, 2015

Looks pretty legit! 👍

@donnielrt

This comment has been minimized.

Show comment
Hide comment
@donnielrt

donnielrt Sep 24, 2015

Contributor

Thanks Shawn!

Contributor

donnielrt commented Sep 24, 2015

Thanks Shawn!

donnielrt added a commit that referenced this pull request Sep 24, 2015

Merge pull request #306 from mobify/ios-preload-hit-fix
Added iOS8 preload-top-hits issue fix for v7 tag

@donnielrt donnielrt merged commit 4a4ff8a into v2.0 Sep 24, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@donnielrt donnielrt deleted the ios-preload-hit-fix branch Sep 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment