Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix accordion bug in latest Chrome and Firefox #97

Merged
merged 3 commits into from Feb 20, 2013

Conversation

Projects
None yet
3 participants
Contributor

jansepar commented Feb 14, 2013

Fix according by binding all browser-specific transitionend events. Detection mechanism we use to determine which transitionend event to use is broken in Chrome dev build (26) and Firefox 18. Likely a bug to send to browser venders (TODO: Writeup minimal testcase on JSFiddle!)

Fix according by binding all browser-specific transitionend events. D…
…etection mechanism we use to determine which transitionend event to use is broken in Chrome dev build (26) and Firefox 18. Likely a bug to send to browser venders (TODO: Writeup minimal testcase on JSFiddle!)
Contributor

jansepar commented Feb 14, 2013

Refs #96

@jansepar Where my comments at? Why are we using two events here again?

Contributor

jansepar replied Feb 15, 2013

The codesnippet here is from stack overflow, which is taken from Modernizr:

http://stackoverflow.com/questions/5023514/how-do-i-normalize-css3-transition-functions-across-browsers/9090128#9090128

Seems it has been updated recently to use transitionend instead of transitionEnd on Firefix (read the comments on the accepted answer). Since I'm not sure if this is the case for ALL browsers, I left it on both events just incase (it doesn't hurt!). Also, another comment was that Opera updated to all lowercase - should fix that as well!

Owner

noahadams commented Feb 20, 2013

tested working on current firefox/chrome/opera and safari, and up to date aurora and canary

Owner

noahadams commented Feb 20, 2013

👍

noahadams added a commit that referenced this pull request Feb 20, 2013

Merge pull request #97 from mobify/fix-accordion
fix accordion bug in latest Chrome and Firefox

@noahadams noahadams merged commit 2585b16 into master Feb 20, 2013

1 check passed

default
Details
Owner

noahadams commented Feb 20, 2013

fixes #96

@tedtate tedtate deleted the fix-accordion branch Dec 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment