Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/lib: try to pass specialArgs to eval #354

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

Pacman99
Copy link

@Pacman99 Pacman99 commented May 6, 2021

fixes #353

Allows hosts to make use of specialArgs if they are using a new enough version of nixpkgs and lib/evalModules. Specifically the change from NixOS/nixpkgs#121870 is needed. I don't think there is any way to fix this problem for people using older versions.

@samueldr
Copy link
Member

samueldr commented May 7, 2021

Let's wait for at least one nixos-unstable bump with the required changes. (Unless this evaluates properly on the current unstable when you're not using specialArgs...)

@Pacman99
Copy link
Author

Pacman99 commented May 7, 2021

Unless this evaluates properly on the current unstable when you're not using specialArgs

I'm not sure if I understand this right, but this should evaluate properly on any nixpkgs version because of the args.specialArgs or { }. So it only helps if your using the latest nixpkgs. But I don't think it can hurt whether or not you use specialArgs. I might be missing some possible error from this, not sure.

But waiting makes sense for general stability.

@samueldr
Copy link
Member

samueldr commented May 7, 2021

(To be fair I haven't yet looked at the PR, so when I'll take a look or if someone else does in-depth testing we'll see :))

@colemickens
Copy link
Contributor

Have you had a chance to test this @Pacman99 ?

@Pacman99
Copy link
Author

I have tested that this PR evaluates with a mobile-nixos build - couldn't get it to actually build for unrelated reasons. And I just used this concept over at divnix/digga#51 which essentially does the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Can't use specialArgs
3 participants