New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch parse_params() to deal with BSD strtol() #129

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@peterjeremy
Contributor

peterjeremy commented Apr 10, 2012

strtol(3) can optionally set errno to EINVAL if no conversion could be
performed and FreeBSD (at least) implements thin behaviour. Add an
explicit test to detect this situation in Dispatcher::parse_params().
(This behaviour difference is not relevant to other uses of strtol()).

This corrects the mishandling of (eg) "CSI m" on FreeBSD.

strtol(3) can optionally set errno to EINVAL if no conversion could be
performed and FreeBSD (at least) implements thin behaviour.  Add an
explicit test to detect this situation in Dispatcher::parse_params().
(This behaviour difference is not relevant to other uses of strtol()).

This corrects the mishandling of (eg) "CSI m" on FreeBSD.
@peterjeremy

This comment has been minimized.

Show comment
Hide comment
@peterjeremy

peterjeremy Apr 10, 2012

Contributor

This should be linked to #126 but I have no idea how to make github do that.

Contributor

peterjeremy commented Apr 10, 2012

This should be linked to #126 but I have no idea how to make github do that.

@keithw

This comment has been minimized.

Show comment
Hide comment
@keithw

keithw Apr 11, 2012

Member

Thanks for this -- we will merge it.

Member

keithw commented Apr 11, 2012

Thanks for this -- we will merge it.

@wez

This comment has been minimized.

Show comment
Hide comment
@wez

wez Apr 11, 2012

This fixes the weird color bleed I experienced this morning with vim on OSX, and also fixes my regular text color in zsh

wez commented on 37c86a9 Apr 11, 2012

This fixes the weird color bleed I experienced this morning with vim on OSX, and also fixes my regular text color in zsh

This comment has been minimized.

Show comment
Hide comment
@wez

wez replied Apr 11, 2012

See also: mobile-shell#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment