Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch parse_params() to deal with BSD strtol() #129

Closed
wants to merge 1 commit into from

Conversation

@peterjeremy
Copy link
Contributor

@peterjeremy peterjeremy commented Apr 10, 2012

strtol(3) can optionally set errno to EINVAL if no conversion could be
performed and FreeBSD (at least) implements thin behaviour. Add an
explicit test to detect this situation in Dispatcher::parse_params().
(This behaviour difference is not relevant to other uses of strtol()).

This corrects the mishandling of (eg) "CSI m" on FreeBSD.

performed and FreeBSD (at least) implements thin behaviour.  Add an
explicit test to detect this situation in Dispatcher::parse_params().
(This behaviour difference is not relevant to other uses of strtol()).

This corrects the mishandling of (eg) "CSI m" on FreeBSD.
@peterjeremy
Copy link
Contributor Author

@peterjeremy peterjeremy commented Apr 10, 2012

This should be linked to #126 but I have no idea how to make github do that.

@keithw
Copy link
Member

@keithw keithw commented Apr 11, 2012

Thanks for this -- we will merge it.

@wez

This comment has been minimized.

Copy link

@wez wez commented on 37c86a9 Apr 11, 2012

This fixes the weird color bleed I experienced this morning with vim on OSX, and also fixes my regular text color in zsh

This comment has been minimized.

Copy link

@wez wez replied Apr 11, 2012

See also: mobile-shell#110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants