Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

configure.ac ncurses detection bugfix #194

Merged
merged 1 commit into from Apr 16, 2012

Conversation

Projects
None yet
4 participants
Contributor

blblack commented Apr 16, 2012

Simple bugfix to configure.ac ncurses stuff in master branch, I believe.

Member

andersk commented Apr 16, 2012

Oops, you’re right.

Please reformat your commit message according to the DISCUSSION section of git help commit, that is, with a one line summary followed by a blank line followed by a body.

Contributor

blblack commented Apr 16, 2012

Fair enough :). What's the acceptable way to do that in github land at this point? Amend the commit locally and push with force to replace it in my shallow fork, since nobody's really actively pulling off of this anyways?

Member

andersk commented Apr 16, 2012

Yes.

Fix ncurses detection at configure time
There appears to be a typo/thinko in the ncurses detection
stuff in configure.ac.  The fallout was that on a Linux host
without ncurses-devel installed, "./configure" failed to find
curses.h but claimed overall success, then the build failed
later during make.  This patch removes an extraneous comma, which
seems to make it both fail and succeed correctly when it should.
Contributor

saurik commented Apr 16, 2012

@blblack In the future, if you cared about not doing a push -f to master of your fork, you can create a feature branch specifically for purposes of the pull request (which tracks a branch, not a specific commit).

@keithw keithw merged commit 6c04291 into mobile-shell:master Apr 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment