Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix lingering issues from #137 #380

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

sqweek commented Jan 19, 2013

  1. Allow mosh to support OSC sequences of the form ESC];foo^G, interpreting them the same as ESC]0;foo^G

  2. Avoid changing the window title of the client if the title has never been set upstream.

(I made the changes you requested, osc_received is now title_initialized and I signed off the commits).

sqweek added some commits Jan 18, 2013

Treat empty OSC number as zero.
For interoperability's sake, accept OSCs of the form ESC];title^G
treating them the same as ESC]0;title^G

Signed-off-by: sqweek <sqweek@gmail.com>
Don't touch window title before an OSC is received.
Fixes the "window title being clobbered" issue raised in issue 137.

Signed-off-by: sqweek <sqweek@gmail.com>

Thanks for writing this patch, squeek. My question is sortof for keithw, but also for you. Does this patch actually solve the problem? In my case, I set the local terminal title first (using escape sequences), then I launch mosh. I want mosh to avoid changing the window title EVEN IF the title has been set upstream (i.e. beforehand, via escape sequences). I am setting MOSH_TITLE_NOPREFIX=1, but it appears that mosh still overrides my window title with 'mosh-client'. It appears the [mosh] prefix is correctly suppressed in this case, but it does not appear to achieve my desired behaviour. Thanks for your time!

Contributor

sqweek commented Mar 8, 2013

It solves the problems it aims to, yes. That is, the window title is no longer clobbered to the empty string when a new mosh session begins.

You are correct that it doesn't do what you want - upstream title changes will still always be forwarded to the local terminal.

@keithw keithw closed this in 5af90cc Mar 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment