Add support for italic #443

Closed
wants to merge 1 commit into
from

4 participants

@Tracerneo

SGR (Select Graphic Rendition) code 3
Test with echo -e "\033[3mitalic\033[0m"
Supported in rxvt-unicode.

@keithw keithw added a commit that closed this pull request Jul 1, 2013
@Tracerneo Tracerneo Add support for ECMA-48 escape sequence for italic
Closes #443
06561d3
@keithw keithw closed this in 06561d3 Jul 1, 2013
@keithw
Mosh (mobile shell) member

Thanks very much!

On an unrelated note, we do have some problems with rxvt-unicode (see #178) and rxvt-unicode has some problems with us (see http://comments.gmane.org/gmane.comp.terminal-emulators.rxvt-unicode.general/1157). But I don't think there's any reason to be shy about supporting this rendition attribute.

@antrorsum antrorsum added a commit to antrorsum/mosh that referenced this pull request Jul 6, 2013
@antrorsum antrorsum Squashed commit of the following:
commit c6bf3a2
Author: Barosl LEE <vcs@barosl.com>
Date:   Wed May 29 12:54:29 2013 +0900

    Implement bracketed paste mode

    Allow bracketed paste mode-setting control sequences to be passed to the
    outer terminal.

    Signed-off-by: Barosl LEE <vcs@barosl.com>

    Closes #430

commit 06561d3
Author: Daniel "Tracerneo" Ziółkowski <ziolkoneo@gmail.com>
Date:   Fri Jun 28 04:28:32 2013 +0200

    Add support for ECMA-48 escape sequence for italic

    Closes #443

commit d871161
Author: Andrew Chin <achin@eminence32.net>
Date:   Tue May 14 19:58:58 2013 -0400

    Set MACOSX_DEPLOYMENT_TARGET so that older macs can run the mosh binaries

    Closes #424

commit c3e31f1
Author: Keith Winstein <keithw@mit.edu>
Date:   Wed Jun 5 19:19:05 2013 +0200

    Get rid of obsolete DM-Upload-Allowed field

commit f960a8b
Author: Timo J. Rinne <tri@iki.fi>
Date:   Thu May 16 18:09:15 2013 +0000

    mosh-client: Make terminal escape character configurable

    Uses environment variable MOSH_ESCAPE_KEY. Defaults to current Ctrl-^
    which is somewhat problematic for many non-US keyboards.

    Signed-off-by: Timo J. Rinne <tri@iki.fi>

    Closes #425. Closes #215.

commit 4792992
Author: Keith Winstein <keithw@mit.edu>
Date:   Sun Apr 28 15:33:36 2013 -0400

    Rename --bind-ip to --bind-server, add =ANY option, add error checking.

    Closes #415.

commit fc70612
Author: Philipp Haselwarter <philipp@haselwarter.org>
Date:   Tue Apr 16 18:37:40 2013 +0200

    mosh perl wrapper: New option --bind-ip={ssh|IP}

    Allow overriding the switch passed to mosh-server from -s to -i IP.

    Signed-off-by: Philipp Haselwarter <philipp@haselwarter.org>

commit 9314ea1
Author: Jérémie Courrèges-Anglas <jca@wxcvbn.org>
Date:   Tue Apr 16 11:11:45 2013 +0200

    use betoh64 if be64toh not found

    Instead of looking for htobe64 which is be available both when
    be64toh or betoh64 are, check for the latter functions.  If we
    find betoh64 but not be64toh, use compat #defines.  If both
    can't be found, search for OSX' OSSwapHostToBigInt64.
    Also include sys/types.h in byteorder.h (which is necessary for
    byteorder functions on OpenBSD), and incidentally fixes build
    of networkfragment.cc.

    Fixes build on OpenBSD

    Signed-off-by: Jérémie Courrèges-Anglas <jca@wxcvbn.org>

commit 24b078a
Author: Jérémie Courrèges-Anglas <jca@wxcvbn.org>
Date:   Tue Apr 16 11:09:42 2013 +0200

    workaround for systems not providing pselect

    using a mix of good old select and sigprocmask

    Signed-off-by: Jérémie Courrèges-Anglas <jca@wxcvbn.org>

commit fbd2d18
Author: Andrew Chin <achin@eminence32.net>
Date:   Sat Mar 30 23:26:52 2013 -0400

    In the OSX build script, link with system libs.

    Previously, mosh was linking with macports-provided libs in
    /opt/local/lib, which was not portable to users without macports

    Closes #411

commit 8ff636d
Author: Anders Kaseorg <andersk@mit.edu>
Date:   Tue Apr 9 18:04:43 2013 -0400

    Work around automake bug that dropped portability warnings

    There’s a bug in automake ≥ 1.10, < 1.12 where ‘-Wall foreign’
    incorrectly turns off warnings about portability issues.  To get
    consistent results across automake versions, use ‘foreign -Wall’
    instead.

    http://debbugs.gnu.org/cgi-bin/bugreport.cgi?bug=7669

    Signed-off-by: Anders Kaseorg <andersk@mit.edu>

    Closes #413

commit fb39fe2
Author: Anton Lundin <glance@acc.umu.se>
Date:   Tue Jan 22 20:29:01 2013 +0100

    Simplify pipe management

    We don't need to write perl like C.

commit 1b9915f
Author: Keith Winstein <keithw@mit.edu>
Date:   Wed Mar 27 18:34:21 2013 -0400

    Bump version to 1.2.4a

commit 9669178
Author: Keith Winstein <keithw@mit.edu>
Date:   Wed Mar 27 15:21:20 2013 -0400

    Eliminate ocb.cc test program (closes #408)

    This test doesn't return an error on failure and also was triggering a
    stack protector warning on some platforms. We have an end-to-end test of
    OCB in src/tests/ocb-aes.cc that seems to work well.

commit 4a37359
Author: Alexander Chernyakhovsky <achernya@mit.edu>
Date:   Wed Mar 27 14:49:58 2013 -0400

    Update mosh.spec for mosh 1.2.4

commit 172b1e5
Author: Alexander Chernyakhovsky <achernya@mit.edu>
Date:   Wed Mar 27 02:15:25 2013 -0400

    Cast time_elapsed to int before calling human_readable_duration

    When attempting to build againt EPEL 5, it was noticed that
    human_readable_duration expects an int, but time_elapsed is an
    integer.  Explicitly static_cast<int>( time_elapsed ) to appease older
    compilers.

commit 688bf21
Author: Keith Winstein <keithw@mit.edu>
Date:   Wed Mar 27 00:28:47 2013 -0400

    Bump version to 1.2.4

commit 61c6ee6
Author: Keith Winstein <keithw@mit.edu>
Date:   Wed Mar 27 00:26:59 2013 -0400

    Send SIGSTOP to whole process group on suspend (closes #401)
c47a8c3
@unphased

Is this PR merged? I am testing mosh 1.2.4 and mosh is either removing my italics or turning them into reverse-color. Basically, mosh is doing translation and not feeding \033[3m to my terminal properly. Yes I have the terminal setting set. https://gist.github.com/sos4nt/3187620

Edit: I noticed 1.2.4 is March 2013 which predates July 6, 2013 where the squashed merge happened. Will compile from source. Will report back if it still does not work. I reckon I will only need to do this on the machine hosting mosh as client...

@andersk
Mosh (mobile shell) member

It is merged in Git master, but not in 1.2.4. You will need to run both the client and the server from Git.

@unphased

Well now the italics work for me inside of a plain terminal, but I still see the same behavior inside tmux which has my italics turn into reverse-color. This warrants some more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment