Add GetMixins to mobilecoind API #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranrund
reviewed
Jan 13, 2021
mobilecoind/src/payments.rs
Outdated
| /// Create a TxProposal that attempts to merge multiple UTXOs into a single larger UTXO. | ||
| /// | ||
| /// # Arguments | ||
| /// * `monitor_id` - ??? |
There was a problem hiding this comment.
I believe this generates a transaction that joins a bunch of UTXOs belonging to monitor_id+subaddress_index
mobilecoind/src/payments.rs
Outdated
| /// Create a TxProposal that sends the total value of all inputs minus the fee to a single receiver. | ||
| /// | ||
| /// # Arguments | ||
| /// * `account_key` - |
There was a problem hiding this comment.
The account key the UTXOs belong to
mobilecoind/src/payments.rs
Outdated
| /// * `fee` - Transaction fee, in picoMOB. | ||
| /// * `from_account_key` - ??? | ||
| /// * `change_subaddress` - ??? | ||
| /// * `destinations` - ??? |
There was a problem hiding this comment.
The outputs of the transaction
mobilecoind/src/payments.rs
Outdated
| /// * `from_account_key` - ??? | ||
| /// * `change_subaddress` - ??? | ||
| /// * `destinations` - ??? | ||
| /// * `tombstone_block` - ??? |
There was a problem hiding this comment.
Tombstone block of the transaction
mobilecoind/src/payments.rs
Outdated
| /// * `change_subaddress` - ??? | ||
| /// * `destinations` - ??? | ||
| /// * `tombstone_block` - ??? | ||
| /// * `fog_pubkey_resolver` - ??? |
There was a problem hiding this comment.
Used to obtain fog report key when fog support is enabled.
mobilecoind/src/payments.rs
Outdated
| /// * `inputs` - UTXOs to spend, with membership proofs. | ||
| /// * `rings` - A set of mixins for each input, with membership proofs. | ||
| /// * `fee` - Transaction fee, in picoMOB. | ||
| /// * `from_account_key` - ??? |
There was a problem hiding this comment.
Account key the inputs belong to and change is sent to
mobilecoind/src/payments.rs
Outdated
| /// * `rings` - A set of mixins for each input, with membership proofs. | ||
| /// * `fee` - Transaction fee, in picoMOB. | ||
| /// * `from_account_key` - ??? | ||
| /// * `change_subaddress` - ??? |
There was a problem hiding this comment.
Subaddress to send change to
mobilecoind/src/service.rs
Outdated
| .map_err(|err| rpc_internal_error("unspent_tx_out.try_from", err, &self.logger)) | ||
| // UnspentTxOut::try_from(tx_out) |
eranrund
approved these changes
Jan 15, 2021
| Ok(Json(response)) | ||
| } | ||
|
|
||
| #[post("/tx-out/mixin", format = "json", data = "<request>")] |
|
@eranrund May JsonBlockDetailsResponse return full data, like JsonTxOut, key images, etc? |
tsegaran
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adds API endpoint for getting TxOuts for use as mixins.
In this PR