New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a failing test for React.forwardRef #606

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@pimterry
Contributor

pimterry commented Nov 17, 2018

This is a failing test to illustrate #602. It fails with:

Error: Uncaught [TypeError: Cannot read property 'displayName' of undefined]

I'm pretty confident that this should work, and that this is the underlying issue that breaks styled components: any components that use ref forwarding can't be passed to observe().

@mweststrate mweststrate merged commit be37147 into mobxjs:master Nov 19, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@mweststrate

This comment has been minimized.

Member

mweststrate commented Nov 19, 2018

Thanks! This was really helpful :)

@pimterry pimterry deleted the pimterry:forwardref-test branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment