From a08a9a53bd43b59c84d561817f5cb7b1c357ba96 Mon Sep 17 00:00:00 2001
From: Pavan Podila <pavan.podila@gmail.com>
Date: Wed, 15 Jan 2020 17:28:37 +0530
Subject: [PATCH] moving write policy inside the group...test!

---
 .idea/workspace.xml        |  35 +++++----
 mobx/test/action_test.dart | 143 +++++++++++++++++++------------------
 2 files changed, 94 insertions(+), 84 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index bb03732ab..5e3b17441 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -257,7 +257,7 @@
       <workItem from="1578880952636" duration="1815000" />
       <workItem from="1578935064823" duration="13000" />
       <workItem from="1578935091427" duration="986000" />
-      <workItem from="1579017372100" duration="3795000" />
+      <workItem from="1579017372100" duration="4558000" />
     </task>
     <task id="LOCAL-00001" summary="adding documentation to the public methods...WIP">
       <created>1573311043900</created>
@@ -581,7 +581,14 @@
       <option name="project" value="LOCAL" />
       <updated>1579087379687</updated>
     </task>
-    <option name="localTasksCounter" value="47" />
+    <task id="LOCAL-00047" summary="moving write policy inside the group...test!">
+      <created>1579087555958</created>
+      <option name="number" value="00047" />
+      <option name="presentableId" value="LOCAL-00047" />
+      <option name="project" value="LOCAL" />
+      <updated>1579087555958</updated>
+    </task>
+    <option name="localTasksCounter" value="48" />
     <servers />
   </component>
   <component name="TypeScriptGeneratedFilesManager">
@@ -697,12 +704,12 @@
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state x="1118" y="404" key="#xdebugger.evaluate/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1577977075071" />
-    <state x="351" y="147" key="CommitChangelistDialog2" timestamp="1579087379538">
+    <state x="351" y="147" key="CommitChangelistDialog2" timestamp="1579087555836">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state x="351" y="147" key="CommitChangelistDialog2/0.23.1680.1027@0.23.1680.1027" timestamp="1577591843148" />
     <state x="351" y="147" key="CommitChangelistDialog2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1573311043628" />
-    <state x="351" y="147" key="CommitChangelistDialog2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087379538" />
+    <state x="351" y="147" key="CommitChangelistDialog2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087555836" />
     <state width="481" height="466" key="DebuggerActiveHint" timestamp="1578496148462">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
@@ -717,30 +724,30 @@
     </state>
     <state x="446" y="343" key="EditFileWatcherDialog/0.23.1680.1027@0.23.1680.1027" timestamp="1576815875205" />
     <state x="446" y="343" key="EditFileWatcherDialog/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1577761297729" />
-    <state width="1270" height="278" key="GridCell.Tab.0.bottom" timestamp="1579087048483">
+    <state width="1270" height="278" key="GridCell.Tab.0.bottom" timestamp="1579089503290">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state width="1140" height="278" key="GridCell.Tab.0.bottom/0.23.1680.1027@0.23.1680.1027" timestamp="1578627200696" />
     <state width="1878" height="288" key="GridCell.Tab.0.bottom/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1576166795304" />
-    <state width="1270" height="278" key="GridCell.Tab.0.bottom/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087048483" />
-    <state width="1270" height="278" key="GridCell.Tab.0.center" timestamp="1579087048481">
+    <state width="1270" height="278" key="GridCell.Tab.0.bottom/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579089503290" />
+    <state width="1270" height="278" key="GridCell.Tab.0.center" timestamp="1579089503290">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state width="1140" height="278" key="GridCell.Tab.0.center/0.23.1680.1027@0.23.1680.1027" timestamp="1578627200695" />
     <state width="1878" height="288" key="GridCell.Tab.0.center/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1576166795303" />
-    <state width="1270" height="278" key="GridCell.Tab.0.center/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087048481" />
-    <state width="1270" height="278" key="GridCell.Tab.0.left" timestamp="1579087048481">
+    <state width="1270" height="278" key="GridCell.Tab.0.center/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579089503290" />
+    <state width="1270" height="278" key="GridCell.Tab.0.left" timestamp="1579089503289">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state width="1140" height="278" key="GridCell.Tab.0.left/0.23.1680.1027@0.23.1680.1027" timestamp="1578627200695" />
     <state width="1878" height="288" key="GridCell.Tab.0.left/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1576166795302" />
-    <state width="1270" height="278" key="GridCell.Tab.0.left/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087048481" />
-    <state width="1270" height="278" key="GridCell.Tab.0.right" timestamp="1579087048482">
+    <state width="1270" height="278" key="GridCell.Tab.0.left/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579089503289" />
+    <state width="1270" height="278" key="GridCell.Tab.0.right" timestamp="1579089503290">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state width="1140" height="278" key="GridCell.Tab.0.right/0.23.1680.1027@0.23.1680.1027" timestamp="1578627200695" />
     <state width="1878" height="288" key="GridCell.Tab.0.right/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1576166795304" />
-    <state width="1270" height="278" key="GridCell.Tab.0.right/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087048482" />
+    <state width="1270" height="278" key="GridCell.Tab.0.right/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579089503290" />
     <state width="1152" height="345" key="GridCell.Tab.1.bottom" timestamp="1578502180992">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
@@ -794,12 +801,12 @@
     </state>
     <state width="515" height="445" key="SwitcherDM/0.23.1680.1027@0.23.1680.1027" timestamp="1577601957656" />
     <state width="515" height="445" key="SwitcherDM/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1577976796509" />
-    <state x="440" y="279" key="Vcs.Push.Dialog.v2" timestamp="1579087381314">
+    <state x="440" y="279" key="Vcs.Push.Dialog.v2" timestamp="1579087557551">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
     <state x="440" y="279" key="Vcs.Push.Dialog.v2/0.23.1680.1027@0.23.1680.1027" timestamp="1577591905835" />
     <state x="263" y="-794" key="Vcs.Push.Dialog.v2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@-240.-1057.1920.1057" timestamp="1573311047244" />
-    <state x="440" y="279" key="Vcs.Push.Dialog.v2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087381314" />
+    <state x="440" y="279" key="Vcs.Push.Dialog.v2/1680.-1057.1920.1057/-240.-1057.1920.1057/0.23.1680.1027@0.23.1680.1027" timestamp="1579087557551" />
     <state width="840" height="513" key="XDebugger.FullValuePopup" timestamp="1577976713603">
       <screen x="0" y="23" width="1680" height="1027" />
     </state>
diff --git a/mobx/test/action_test.dart b/mobx/test/action_test.dart
index 0030993ac..ab758c54c 100644
--- a/mobx/test/action_test.dart
+++ b/mobx/test/action_test.dart
@@ -6,8 +6,6 @@ import 'shared_mocks.dart';
 import 'util.dart';
 
 void main() {
-  turnOffWritePolicy();
-
   group('Action', () {
     turnOffWritePolicy();
 
@@ -219,102 +217,107 @@ void main() {
     });
   });
 
-  test('runInAction works', () {
-    final x = Observable(10);
-    final y = Observable(20);
-
-    var executionCount = 0;
-    var total = 0;
-
-    final d = autorun((_) {
-      total = x.value + y.value;
-      executionCount++;
-    });
-
-    runInAction(() {
-      x.value = 100;
-      y.value = 200;
+  group('Action utility functions', () {
+    turnOffWritePolicy();
 
-      expect(executionCount, equals(1)); // No notifications are fired
-    });
+    test('runInAction works', () {
+      final x = Observable(10);
+      final y = Observable(20);
 
-    // Notifications are fired now
-    expect(executionCount, equals(2));
-    expect(total, equals(300));
+      var executionCount = 0;
+      var total = 0;
 
-    d();
-  });
+      final d = autorun((_) {
+        total = x.value + y.value;
+        executionCount++;
+      });
 
-  test('transaction works', () {
-    mainContext.config = ReactiveConfig(writePolicy: ReactiveWritePolicy.never);
+      runInAction(() {
+        x.value = 100;
+        y.value = 200;
 
-    final x = Observable(10);
-    final y = Observable(20);
+        expect(executionCount, equals(1)); // No notifications are fired
+      });
 
-    var total = 0;
+      // Notifications are fired now
+      expect(executionCount, equals(2));
+      expect(total, equals(300));
 
-    final d = autorun((_) {
-      total = x.value + y.value;
+      d();
     });
 
-    transaction(() {
-      x.value = 100;
-      y.value = 200;
-
-      // within a transaction(), there are no notifications fired, so the total should not change
-      expect(total, equals(30));
-    });
+    test('transaction works', () {
+      mainContext.config =
+          ReactiveConfig(writePolicy: ReactiveWritePolicy.never);
 
-    // Notifications fire now, causing autorun() to execute
-    expect(total, equals(300));
+      final x = Observable(10);
+      final y = Observable(20);
 
-    d();
+      var total = 0;
 
-    mainContext.config = ReactiveConfig.main;
-  });
+      final d = autorun((_) {
+        total = x.value + y.value;
+      });
 
-  test('untracked works', () {
-    final x = Observable(0);
-    var count = 0;
+      transaction(() {
+        x.value = 100;
+        y.value = 200;
 
-    final d = autorun((_) {
-      // No tracking should be performed since we are reading inside untracked()
-      untracked(() {
-        x.value;
+        // within a transaction(), there are no notifications fired, so the total should not change
+        expect(total, equals(30));
       });
 
-      count++;
+      // Notifications fire now, causing autorun() to execute
+      expect(total, equals(300));
+
+      d();
+
+      mainContext.config = ReactiveConfig.main;
     });
 
-    expect(count, equals(1));
+    test('untracked works', () {
+      final x = Observable(0);
+      var count = 0;
 
-    x.value = 100;
+      final d = autorun((_) {
+        // No tracking should be performed since we are reading inside untracked()
+        untracked(() {
+          x.value;
+        });
 
-    // Should be no change in count
-    expect(count, equals(1));
+        count++;
+      });
 
-    d();
-  });
+      expect(count, equals(1));
 
-  test('runInAction return type', () {
-    final x = Observable(10);
+      x.value = 100;
 
-    var executionCount = 0;
-    var total = 0;
+      // Should be no change in count
+      expect(count, equals(1));
 
-    final d = autorun((_) {
-      total = x.value;
-      executionCount++;
+      d();
     });
 
-    final value = runInAction(() => x.value = 100);
+    test('runInAction return type', () {
+      final x = Observable(10);
+
+      var executionCount = 0;
+      var total = 0;
+
+      final d = autorun((_) {
+        total = x.value;
+        executionCount++;
+      });
 
-    expect(value, equals(100));
+      final value = runInAction(() => x.value = 100);
 
-    // Notifications are fired now
-    expect(executionCount, equals(2));
-    expect(total, equals(100));
+      expect(value, equals(100));
 
-    d();
+      // Notifications are fired now
+      expect(executionCount, equals(2));
+      expect(total, equals(100));
+
+      d();
+    });
   });
 }