shouldComponentUpdate does not work

[MikeTatsky]

Hi there,
I am sorry for disturbing.
We have very complex app and we faced the problem that shouldComponentUpdate in some cases work, in some it does not with the same code.
We read that it is not recommended to use shouldComponentUpdate for MobX.
But we use ag-Grid and since it is not written on React, it can not be updated properly and fast for React over changing states. The only way to work fast for ag-Grid with React is using ag-Grid methods.
We need to rerending updating grids container.
Our code definition looks like this.

@inject('sheetStore')
@observer
export default class GridContainer extends Component {
...
Many grids rendering
...
//Accidentally it stops to work
shouldComponentUpdate = () => {
    if (sheetStore.stopReRenderingGrids) {
      return false;
    }

    return true;
}

Sorely I can not provide link on sample for this case.
Please, give me advice.

[urugator]

Firstly don't use arrow functions () => {} for lifecycle methods.

When using @observer on a component, don't implement shouldComponentUpdate, as it will override the default implementation that MobX provides. When using mobx-react, you should in general not need to write an sCU (in our entire Mendix code base we have none). If you really need to implement sCU, split the component into two, a reactive and non-reactive (with the sCU) part, or use sections instead of observer on the entire component.

Also check mobxjs/mobx-react#667 (comment)

[ItamarShDev]

https://github.com/mobxjs/mobx-react#about-shouldcomponentupdate
this is the docs segment @urugator was referencing.

[mweststrate]

Was the question solved?

[MikeTatsky]

@mweststrate
Thank you Michel,
We use use usual property without observable and it looks like it works so no need in shouldComponentUpdate for the moment.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or questions.