From 020073bcaf99e50b0a2d7f73e23a59d30b036a8b Mon Sep 17 00:00:00 2001 From: CrazyMax <1951866+crazy-max@users.noreply.github.com> Date: Wed, 29 Nov 2023 17:48:20 +0100 Subject: [PATCH] llbsolver: fix possible panic when setting event to nil When a record is marked for deletion the event is set to nil but we don't check if it's nil when sending events which could cause a panic. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> (cherry picked from commit 9d39af0e62ca55600ddb5991997b93507172c006) --- solver/llbsolver/history.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solver/llbsolver/history.go b/solver/llbsolver/history.go index d7ca60a08936..d055a7bf54f0 100644 --- a/solver/llbsolver/history.go +++ b/solver/llbsolver/history.go @@ -819,7 +819,7 @@ func (h *HistoryQueue) Listen(ctx context.Context, req *controlapi.BuildHistoryR } h.mu.Unlock() for _, e := range events { - if e.Record == nil { + if e == nil || e.Record == nil { continue } if err := f(e); err != nil {