diff --git a/frontend/dockerfile/instructions/parse.go b/frontend/dockerfile/instructions/parse.go index f26ff07ded012..9c1c7ea379b92 100644 --- a/frontend/dockerfile/instructions/parse.go +++ b/frontend/dockerfile/instructions/parse.go @@ -78,7 +78,7 @@ func ParseInstructionWithLinter(node *parser.Node, lint *linter.Linter) (v inter req := newParseRequestFromNode(node) switch strings.ToLower(node.Value) { case command.Env: - return parseEnv(req, lintWarn) + return parseEnv(req, lint) case command.Maintainer: if lint != nil { msg := linter.RuleMaintainerDeprecated.Format() @@ -86,7 +86,7 @@ func ParseInstructionWithLinter(node *parser.Node, lint *linter.Linter) (v inter } return parseMaintainer(req) case command.Label: - return parseLabel(req, lintWarn) + return parseLabel(req, lint) case command.Add: return parseAdd(req) case command.Copy: @@ -195,7 +195,7 @@ func Parse(ast *parser.Node, lint *linter.Linter) (stages []Stage, metaArgs []Ar return stages, metaArgs, nil } -func parseKvps(args []string, cmdName string, location []parser.Range, lint linter.LintWarnFunc) (KeyValuePairs, error) { +func parseKvps(args []string, cmdName string, location []parser.Range, lint *linter.Linter) (KeyValuePairs, error) { if len(args) == 0 { return nil, errAtLeastOneArgument(cmdName) } @@ -211,14 +211,14 @@ func parseKvps(args []string, cmdName string, location []parser.Range, lint lint name, value, sep := args[j], args[j+1], args[j+2] if sep == "" { msg := linter.RuleLegacyKeyValueFormat.Format(cmdName) - linter.RuleLegacyKeyValueFormat.Run(lint, location, msg) + lint.Run(&linter.RuleLegacyKeyValueFormat, location, msg) } res = append(res, KeyValuePair{Key: name, Value: value}) } return res, nil } -func parseEnv(req parseRequest, lint linter.LintWarnFunc) (*EnvCommand, error) { +func parseEnv(req parseRequest, lint *linter.Linter) (*EnvCommand, error) { if err := req.flags.Parse(); err != nil { return nil, err } @@ -246,7 +246,7 @@ func parseMaintainer(req parseRequest) (*MaintainerCommand, error) { }, nil } -func parseLabel(req parseRequest, lint linter.LintWarnFunc) (*LabelCommand, error) { +func parseLabel(req parseRequest, lint *linter.Linter) (*LabelCommand, error) { if err := req.flags.Parse(); err != nil { return nil, err }