Add support for weak ProgressGroup membership. #2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
force-pushed
the
progress-order
branch
from
d1232a0
to
31e6d71
Compare
sipsma
force-pushed
the
progress-order
branch
from
31e6d71
to
c52fa8c
Compare
|
Marking as do-not-merge because it includes a commit currently in a separate PR: #2675 |
sipsma
changed the title
sipsma
force-pushed
the
progress-order
branch
from
c52fa8c
to
92bb613
Compare
tonistiigi
approved these changes
Feb 25, 2022
solver/pb/ops.proto
Outdated
| @@ -254,6 +254,7 @@ message ExportCache { | |||
| message ProgressGroup { | |||
| string id = 1; | |||
| string name = 2; | |||
| bool weak = 3; | |||
There was a problem hiding this comment.
Something wrong with whitespace here
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
A ProgressGroup will now only be displayed if a vertex member marked as non-weak has started. Signed-off-by: Erik Sipsma <erik@sipsma.dev>
sipsma
force-pushed
the
progress-order
branch
from
92bb613
to
cc1499e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ProgressGroup will now only be displayed if a vertex member marked as
non-weak has started.
Signed-off-by: Erik Sipsma erik@sipsma.dev