ocaml: update dependencies and harden the notification loop #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the dependencies have been renamed (e.g. cstruct.lwt to cstruct-lwt). Signed-off-by: David Scott <dave@recoil.org>
Since some users have observed spinning, it could be that the system thinks the fd should be blocking but it is actually non-blocking and returning immediately. Signed-off-by: David Scott <dave@recoil.org>
The `Lwt_unix.read` is supposed to return 0 for EOF and >0 for number of bytes read. Error results from the syscall are supposed to be handled by the library. However there is evidence that an error `-1` is leaking through, so add some logging and exit the process instead of spinning. Signed-off-by: David Scott <dave@recoil.org>
Signed-off-by: David Scott <dave@recoil.org>
We should be able to rely on the version constraints in the hyperkit.opam instead. Signed-off-by: David Scott <dave@recoil.org>
Collaborator
Author
2 tasks
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opampackage manager version 2There is some evidence that the notification loop is spinning, due to an
Lwt_unix.readcall returning-1: docker/for-mac#3499 (comment) . This is not supposed to happen but perhaps it is possible if the fd is set to the wrong blocking mode, such that-1,EAGAINare returned but not handled correctly.This PR
<0, which will highlight the problem and prevent spinning