tty: write filename in a file, don't symlink to /dev #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the osquery tool[1] is running and scanning a directory containing the
ttysymlink, it will follow the link to/dev/ttys*and start some kind of infinite loop involving the debug console. This causes hyperkit's CPU to spike and for the console itself to be spammed with it's own output.The easiest workaround is to not create the symlink, but write the name of the tty in a file instead. Therefore for debugging we can still run
(or equivalent)
Reported originally around here[2]
[1] https://osquery.io/downloads/
[2] docker/for-mac#3499 (comment)
Signed-off-by: David Scott dave@recoil.org