Fix compilation issues for Big Sur #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiler warning is used for cross-compilation only, which is not used for hyperkit. Explicitly disable it. Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
macOS Big Sur seems to have introduced their own version of
these functions. Use an _ to pick up our version of these
functions.
This is based on b7e589f91e68 ("Support Big Sur (moby#200)")
from https://github.com/machyve/xhyve
Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
hv_vm_create() returns a generic HV_ERROR. Add a case for it. While at it, also print the error value in hex as this is how they are defined in hv_error.h. Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
fixes moby#305 Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
This is a temporary file being created by some of the tests. Signed-off-by: Rolf Neugebauer <rn@rneugeba.io>
Closed
djs55
approved these changes
Dec 7, 2020
Collaborator
djs55
left a comment
djs55
left a comment
There was a problem hiding this comment.
Makes sense, and the CI is green!
Contributor
|
I think you need #295 as well. Only if that would get merged... |
|
Would it be possible to get a release that includes this patch? 🙏 Oddly, this library is blocking Homebrew from updating Go 1.15.6. |
Collaborator
|
@arbourd I've tagged a release of hyperkit here: https://github.com/moby/hyperkit/tree/v0.20210107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiling hyperkit on macOS Big Sur.
The resulting binary still does not work, I'm now getting: