Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile Keys for Setting TTY (-t) and Keep STDIN Open (-i) #1870

Closed
groundwater opened this issue Sep 12, 2013 · 6 comments

Comments

Projects
None yet
5 participants
@groundwater
Copy link

commented Sep 12, 2013

I tread docker containers like self-contained executables. The ENTRYPOINT key is great for this, but I often use a command-prompt entry point.

The default docker run is pretty useless without the -t -i commands. I would like to add two Dockerfile keys that set these as default options.

I see two routes here:

  1. an explicit key for each option e.g. OPENSTDIN and TTY
  2. a general FLAG XXX option for setting multiple flags e.g.
FLAG -i (or OPENSTDIN)
FLAG -t (or TTY)

Open to suggestions, but I thought I'd get the dialogue going.

cc/ @shykes

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Sep 12, 2013

I like having explicit instructions like:

STDIN
STDOUT
TTY

instead of a FLAG where people can pass arbitrary options.

What does everyone else think? @vieux @creack

@jpetazzo

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2013

+1 on explicit instructions (it's also a bit more readable IMHO!)

@crosbymichael

This comment has been minimized.

Copy link
Member

commented Sep 13, 2013

I tagged this as an easy fix.

scottbessler added a commit to relateiq/docker that referenced this issue Nov 8, 2013

@crosbymichael crosbymichael removed this from the 0.9.0 milestone Mar 3, 2014

@joshk0

This comment has been minimized.

Copy link

commented Apr 1, 2014

This issue has been open for a very long time. Anything preventing the relateiq/docker change from going into mainline? It looks fine to me.

@creack

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2014

reopened the PR

creack added a commit to creack/docker that referenced this issue Apr 1, 2014

add interactive and tty to dockerfile, closes moby#1870
Docker-DCO-1.1-Signed-off-by: Scott Bessler <scottbessler@gmail.com> (github: creack)
@creack

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2014

Closing in favor of #4955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.