Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: daemon option --default-shm-size #29492

Closed
flx42 opened this issue Dec 16, 2016 · 5 comments · Fixed by #29692
Closed

RFE: daemon option --default-shm-size #29492

flx42 opened this issue Dec 16, 2016 · 5 comments · Fixed by #29692
Labels
area/daemon kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Milestone

Comments

@flx42
Copy link
Contributor

flx42 commented Dec 16, 2016

We run containerized high-performance applications in my team, some of them have a multi-process approach to parallelism, for instance the Microsoft Cognitive Toolkit.
The default size for /dev/shm is 64MB, which is often largely insufficient for our applications running on high-end machines. We need to remember to set --shm-size for each docker run we do.

Thus, it would be very helpful to have a daemon configuration option to set the default value.
@justincormack: you mentioned implementing this here. Below, you also mentioned doing the same for sysctl, that would also be helpful for us.

@justincormack
Copy link
Contributor

Yes, I am still planning to do the sysctl one soon. Setting a shm-size default should be pretty straightforward - do you want to try to do a PR?

@flx42
Copy link
Contributor Author

flx42 commented Dec 16, 2016

I'll see if I have time. With the holidays season coming, I'm not so sure. But don't wait for me if someone else has time to do it!

@thaJeztah thaJeztah added area/daemon kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny labels Dec 19, 2016
@thaJeztah
Copy link
Member

To prevent ending up with a default-x flag for every option that docker run has; would it be better to (e.g.) have a --container-defaults option, or have a defaults section in the daemon.json?

@justincormack
Copy link
Contributor

@thaJeztah in theory yes, in practise a defaults section in the daemon.json makes sense, but then it breaks the automatic mapping to the daemon cli options, so not quite sure how to do it best.

@yongtang
Copy link
Member

Added a PR #29692 for that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants