New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Compose file with docker stack deploy command #30352

Closed
arun-gupta opened this Issue Jan 22, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@arun-gupta
Contributor

arun-gupta commented Jan 22, 2017

Using Docker 1.13:

Client:
 Version:      1.13.0
 API version:  1.25
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Wed Jan 18 16:20:26 2017
 OS/Arch:      darwin/amd64

Server:
 Version:      1.13.0
 API version:  1.25 (minimum version 1.12)
 Go version:   go1.7.3
 Git commit:   49bf474
 Built:        Wed Jan 18 16:20:26 2017
 OS/Arch:      linux/amd64
 Experimental: true

docker stack deploy couchbase-master gives the error message:

Please specify either a bundle file (with --bundle-file) or a Compose file (with --compose-file).

The directory already has a docker-compose.yml. A default file name should be use if none is specified.

docker stack deploy --compose-file docker-compose.yml couchbase-master feels a bit redundant.

@vdemeester

This comment has been minimized.

Member

vdemeester commented Jan 23, 2017

@arun-gupta as docker stack deploy also supports (in experimental) bundle files, we did not want to rush on having a default file name to look for. But yeah, might be a bit redundant for now and is a little bit different that the usual docker-compose up 👼

@arun-gupta

This comment has been minimized.

Contributor

arun-gupta commented Jan 23, 2017

@vdemeester Docker Compose v2 and v3 commands are compared towards end of the blog at https://blog.couchbase.com/2017/deploy-docker-compose-services-swarm. Minimalist is better :)

@dnephin

This comment has been minimized.

Member

dnephin commented Jan 23, 2017

Defaulting to deploying a docker-compose.yml is not viable given the project plan in #26876.

The "default" behaviour for docker stack deploy in the future should be to accept a "bundle" name and deploy from that. the --compose-file flag is just a "shortcut" to build a bundle and deploy directly in a single command.

In the future we might want to introduce some more subcommands for the old Compose workflows, but I don't know if they would be under docker stack or something else.

@dnephin

This comment has been minimized.

Member

dnephin commented Jan 23, 2017

I think we should close this issue, since it conflicts with the long term plan.

@vdemeester

This comment has been minimized.

Member

vdemeester commented Apr 24, 2018

Closing the issue as it is a docker/cli issue anyway

@vdemeester vdemeester closed this Apr 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment