GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup of #1875
Right now, only the RUN instruction returns a valid error code. If other instruction fails, it should exit with an error code (i.e. ADD).
Is this issue already fixed?
vgeta@ubuntu:~/dockerfiles$ sudo docker build . && echo OK || echo KO
Uploading context 10.24 kB
Step 1 : FROM ubuntu
Step 2 : ADD nothing nothing
2014/01/04 19:44:41 nothing: no such file or directory
there was a PR merged, but I don't know if it covers all instructions, and I don't know if the needed integration tests have been written.
reading the code for #2206, it looks like yes, its fixed, and there are tests for both success and failure
so imo we can close this.
@vgeta yes, it is fixed. #3355
Closed by #2206