Make `docker build` exit with correct codes. #3334

Closed
creack opened this Issue Dec 24, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@creack
Contributor

creack commented Dec 24, 2013

Followup of #1875
Right now, only the RUN instruction returns a valid error code. If other instruction fails, it should exit with an error code (i.e. ADD).

@vgeta

This comment has been minimized.

Show comment
Hide comment
@vgeta

vgeta Jan 5, 2014

Contributor

creack,
Is this issue already fixed?

vgeta@ubuntu:~/dockerfiles$ sudo docker build . && echo OK || echo KO
Uploading context 10.24 kB
Step 1 : FROM ubuntu
---> 8dbd9e392a96
Step 2 : ADD nothing nothing
2014/01/04 19:44:41 nothing: no such file or directory
KO

Contributor

vgeta commented Jan 5, 2014

creack,
Is this issue already fixed?

vgeta@ubuntu:~/dockerfiles$ sudo docker build . && echo OK || echo KO
Uploading context 10.24 kB
Step 1 : FROM ubuntu
---> 8dbd9e392a96
Step 2 : ADD nothing nothing
2014/01/04 19:44:41 nothing: no such file or directory
KO

@SvenDowideit

This comment has been minimized.

Show comment
Hide comment
@SvenDowideit

SvenDowideit Jan 6, 2014

Contributor

there was a PR merged, but I don't know if it covers all instructions, and I don't know if the needed integration tests have been written.

Contributor

SvenDowideit commented Jan 6, 2014

there was a PR merged, but I don't know if it covers all instructions, and I don't know if the needed integration tests have been written.

@jamtur01

This comment has been minimized.

Show comment
Hide comment
@jamtur01

jamtur01 Jan 6, 2014

Contributor
Contributor

jamtur01 commented Jan 6, 2014

@SvenDowideit

This comment has been minimized.

Show comment
Hide comment
@SvenDowideit

SvenDowideit Jan 6, 2014

Contributor

reading the code for #2206, it looks like yes, its fixed, and there are tests for both success and failure

so imo we can close this.

Contributor

SvenDowideit commented Jan 6, 2014

reading the code for #2206, it looks like yes, its fixed, and there are tests for both success and failure

so imo we can close this.

@creack

This comment has been minimized.

Show comment
Hide comment
@creack

creack Jan 6, 2014

Contributor

@vgeta yes, it is fixed. #3355

Contributor

creack commented Jan 6, 2014

@vgeta yes, it is fixed. #3355

@creack creack closed this Jan 6, 2014

@jamtur01

This comment has been minimized.

Show comment
Hide comment
@jamtur01

jamtur01 Jan 6, 2014

Contributor

Closed by #2206

Contributor

jamtur01 commented Jan 6, 2014

Closed by #2206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment