Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonical Dockerfile #39512

Open
andrewhsu opened this issue Jul 12, 2019 · 3 comments

Comments

@andrewhsu
Copy link
Contributor

commented Jul 12, 2019

Would like to have an up-to-date top-level canonical Dockerfile for the repo.

For instance, I'd like to use the new build -o feature to get the dockerd, docker-proxy, docker-init binaries:

$ export DOCKER_BUILDKIT=1
$ docker build --platform=local -o . git://github.com/moby/moby

As in the way https://github.com/docker/buildx/blob/master/Dockerfile is structured.

@tonistiigi @tiborvass @thaJeztah et al. are there other best practices that should go into the Dockerfile for moby/moby to make developer, PR checks, or build/release life easier?

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

We don't have buildkit enabled yet in CI, and the CLI is pinned to 17.06, so that complicates things a bit.

I had a branch doing that, but I'm not sure I pushed it and (erm) it may have gone lost in a broken drive on my machine

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Also see #39340

@thaJeztah

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

and the CLI is pinned to 17.06, so that complicates things a bit

Doh! that's for the tests of course, but doesn't apply to the main Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.