New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If stdin or stdout fail to attach docker should present an error ... not keep going #4792

Closed
SamSaffron opened this Issue Mar 20, 2014 · 8 comments

Comments

Projects
None yet
6 participants
@SamSaffron

SamSaffron commented Mar 20, 2014

On my machine:

% docker run --rm -i -a stdin -a stdout ubuntu echo 1
1
% 

On customers

% docker run --rm -i -a stdin -a stdout ubuntu echo 1
% 

Both running 0.9.0 with aufs and libcontainer.

I suspect the issue is that there is a permission issue and the end user running the command has no permission to to attach stdin or out. In such cases docker should fail out, not keep running gracefully.

@crosbymichael

This comment has been minimized.

Show comment
Hide comment
@crosbymichael

crosbymichael Mar 20, 2014

Contributor

I'm not sure it would be a permission issue. Can you add stderr so we can see the error message?

Contributor

crosbymichael commented Mar 20, 2014

I'm not sure it would be a permission issue. Can you add stderr so we can see the error message?

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron Mar 20, 2014

nothing coming back from -i stderr

but -t

causes:

[error] client.go:2315 Error resize: Error: bad file descriptor

SamSaffron commented Mar 20, 2014

nothing coming back from -i stderr

but -t

causes:

[error] client.go:2315 Error resize: Error: bad file descriptor

@tianon

This comment has been minimized.

Show comment
Hide comment
@tianon

tianon Mar 20, 2014

Member

Looks like you're getting bit by cgroups issues. You should try the fix in #4574 (or wait for 0.9.1, which will include it, but timeframe for 0.9.1 is still somewhat unknown).

Member

tianon commented Mar 20, 2014

Looks like you're getting bit by cgroups issues. You should try the fix in #4574 (or wait for 0.9.1, which will include it, but timeframe for 0.9.1 is still somewhat unknown).

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron Mar 20, 2014

@tianon @crosbymichael I can confirm the cgroups-lite fixed it for these users.

SamSaffron commented Mar 20, 2014

@tianon @crosbymichael I can confirm the cgroups-lite fixed it for these users.

@SamSaffron

This comment has been minimized.

Show comment
Hide comment
@SamSaffron

SamSaffron Mar 27, 2014

@tianon I am able to repro some weird issues even with cgroups, a key reason appears to be images created via "docker commit" vs images created vis "docker build"

cause this be hinting at something?

SamSaffron commented Mar 27, 2014

@tianon I am able to repro some weird issues even with cgroups, a key reason appears to be images created via "docker commit" vs images created vis "docker build"

cause this be hinting at something?

@getvictor

This comment has been minimized.

Show comment
Hide comment
@getvictor

getvictor Apr 5, 2014

Contributor

This issue seems related to #5041

Contributor

getvictor commented Apr 5, 2014

This issue seems related to #5041

@cpuguy83

This comment has been minimized.

Show comment
Hide comment
@cpuguy83

cpuguy83 Aug 14, 2014

Contributor

@SamSaffron Is this still an issue post 1.0?

Looks like it's just a matter of semantics of not being able to commit "-i" and "-t" to an image.

Contributor

cpuguy83 commented Aug 14, 2014

@SamSaffron Is this still an issue post 1.0?

Looks like it's just a matter of semantics of not being able to commit "-i" and "-t" to an image.

@tiborvass

This comment has been minimized.

Show comment
Hide comment
@tiborvass

tiborvass Aug 14, 2014

Collaborator

This issue seems to have been fixed by #4574 like tianon said.
The other issue mentioned about docker commit is quite probably #5041.
I'm closing this. Please comment if you think your issue was not resolved.

Collaborator

tiborvass commented Aug 14, 2014

This issue seems to have been fixed by #4574 like tianon said.
The other issue mentioned about docker commit is quite probably #5041.
I'm closing this. Please comment if you think your issue was not resolved.

@tiborvass tiborvass closed this Aug 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment