Adds test for api attach via websocket #10153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be done in the (improperly named) integration-cli "api" tests instead? |
acbodine
force-pushed
the
api_websocket_test
branch
2 times, most recently
from
a52edfd
to
90fa6e9
Compare
|
I moved it to integration-cli/docker_api_attach_test.go its not strictly cli functionality so I thought it was a good idea to move it to a separate file from the cli attach tests. If you don't think that's right, I'm happy to move it elsewhere. |
|
whoa cool! yay for test only PR :) |
|
LGTM |
acbodine
force-pushed
the
api_websocket_test
branch
4 times, most recently
from
910d6e8
to
7bcae7e
Compare
Signed-off-by: Andrew C. Bodine <acbodine@us.ibm.com>
acbodine
force-pushed
the
api_websocket_test
branch
from
7bcae7e
to
9e37a04
Compare
|
@cpuguy83 does this look alright to you now? |
|
Yep. |
|
LGTM |
LK4D4
added a commit
that referenced
this pull request
Feb 6, 2015
Adds test for api attach via websocket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to validate
/containers/attach/<name>/wsapi endpoint.Signed-off-by: Andrew C. Bodine acbodine@us.ibm.com