Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
TestGetContainersAttachWebsocket: use DOCKER_TEST_HOST if specified #10747
TestGetContainersAttachWebsocket is currently broken on Windows CI tests b/c it has hardcoded unix://var/run/docker.sock. (introduced in #10153.) This change makes use of @icecrime's code in docker_utils and generalizes it with sockConn() to provide a net.Conn by making use of DOCKER_TEST_HOST.
Also fixes the test TestGetContainersAttachWebsocket on windows/darwin.
changed the title from
docker_api_attach_test: fix WS test to use DOCKER_TEST_HOST if specified
TestGetContainersAttachWebsocket: fix WS test to use DOCKER_TEST_HOST if specified
Feb 12, 2015
Got another offender!
Want to try collecting them all in this one PR, or shall I start opening new PRs for each?