New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestBuildAddTarXz(Gz): call xz with '-k' due to bug #10755

Merged
merged 1 commit into from Feb 13, 2015

Conversation

Projects
None yet
4 participants
@ahmetb
Contributor

ahmetb commented Feb 12, 2015

TestBuildAddTarXz/TestBuildAddTarXzGz make exec calls like
'cd %SOME_TEMP_DIR%; xz test.gz' but this fails when called
from integration-cli tests (doesn't fail from msys or cmd shell)
when executed on Windows.

It fails with error: "xz: test.tar: Cannot remove: Permission denied."
Proposing workaround of using the xz --keep argument since keeping
test.tar is harmless and it's already in os.TempDir().

If anybody volunteers to see what's going on, console log is here:
https://jenkins.dockerproject.com/job/Windows-PRs/31/console
I can repro this as well but can't exactly figure out why it happens
only when it's called via go test.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
Label: #windows
Cc: @jfrazelle @unclejack @tiborvass

TestBuildAddTarXz: xz with '-k' due to msys bug
TestBuildAddTarXz/TestBuildAddTarXzGz make exec calls like
'cd %SOME_TEMP_DIR%; xz test.gz' but this fails when called
from integration-cli tests (doesn't fail from msys or cmd shell).

It fails with error: "xz: test.tar: Cannot remove: Permission denied."
Proposing workaround of using the `xz --keep` argument since keeping
test.tar is harmless and it's already in os.TempDir().

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Feb 13, 2015

@jfrazelle this fixed the tests:

  • TestBuildAddTarXz
  • TestBuildAddTarXzGz

https://jenkins.dockerproject.com/job/Windows-PRs/32/console

[PASSED]: build - ADD tar.xz
[PASSED]: build - ADD tar.xz.gz

😂

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 13, 2015

LGTM

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 13, 2015

:D

@tiborvass

This comment has been minimized.

Collaborator

tiborvass commented Feb 13, 2015

LGTM

tiborvass added a commit that referenced this pull request Feb 13, 2015

Merge pull request #10755 from ahmetalpbalkan/win-cli/TestBuildAddTar…
…XzGz-fix

TestBuildAddTarXz(Gz): call xz with '-k' due to bug

@tiborvass tiborvass merged commit 2b5dfb3 into moby:master Feb 13, 2015

1 of 2 checks passed

windows Jenkins build Windows-PRs 32 has failed
Details
janky Jenkins build Docker-PRs 986 has succeeded
Details

@ahmetb ahmetb deleted the ahmetb:win-cli/TestBuildAddTarXzGz-fix branch Feb 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment