integration-cli: use cmd.Stdin instead of cat/tee for TestExportContainerAndImportImage #10793
Conversation
…inerAndImportImage
os.Exec("bash", "-c", dockerBinary) ends up making a call like
bash -c c:\...\docker.exe on windows msys shell, which does not work.
This test makes use of exec.Command.Stdin to pass image back to
docker import.
- Upside: fixes the test on windows
- Downside: cat/tee compatibility is no longer tested in this test case
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
|
Nice! LGTM |
|
+100 LGTM IMO, this is how this test (and similar tests) should've worked in the first place. 👍 |
|
LGTM |
|
LGTM |
I thought it was intentional to test how unix tools work with cli. 😮 @duglin valid concern. in this case image is small, so I ignored it, also in this case I'd prefer runCommandWithOutput to return []byte; not string. |
|
LGTM |
…inerAndImportImage-fix integration-cli: use cmd.Stdin instead of cat/tee for TestExportContainerAndImportImage
TestExportContainerAndImportImage:
os.Exec("bash", "-c", dockerBinary)ends up making a call likebash -c "c:\...\docker.exe"on windows which doesn't work because bash won't accept windows paths and there's no unix path available fordockerBinary.This test makes use of
exec.Command.Stdinto pass thedocker exported image back to docker import usingstrings.Reader.Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
Label:
#windowscc: @tianon @unclejack @jfrazelle @icecrime