Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-cli: Seed rand in makeRandomString #10795

Merged
merged 1 commit into from Feb 16, 2015
Merged

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 14, 2015

Current use of makeRandomString is to create really
long strings. In #10794, I used them to create nearly-unique
unix paths for the daemon. Although collions are harmless and don't
fail the tests, this prevents the same strings from being created
consistently in every run by seeding a rand.Random instance.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @unclejack @jfrazelle

Current uses of `makeRandomString` is to create really
long strings. In #10794, I used them to create nearly-unique
unix paths for the daemon. Although collions are harmless and
don't fail the tests, this prevents the same strings from being
created consistently in every run by seeding rand.Random.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@unclejack
Copy link
Contributor

@unclejack unclejack commented Feb 14, 2015

LGTM

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 16, 2015

cool LGTM

jessfraz pushed a commit that referenced this pull request Feb 16, 2015
…domString

integration-cli: Seed rand in makeRandomString
@jessfraz jessfraz merged commit 546f481 into moby:master Feb 16, 2015
1 check passed
1 check passed
janky Jenkins build Docker-PRs 1075 has succeeded
Details
@ahmetb ahmetb deleted the ahmetb:integration-cli/makeRandomString branch Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.