integration-cli: Seed rand in makeRandomString#10795
Merged
jessfraz merged 1 commit intomoby:masterfrom Feb 16, 2015
ahmetb:integration-cli/makeRandomString
Merged
integration-cli: Seed rand in makeRandomString#10795jessfraz merged 1 commit intomoby:masterfrom ahmetb:integration-cli/makeRandomString
jessfraz merged 1 commit intomoby:masterfrom
ahmetb:integration-cli/makeRandomString
Conversation
Current uses of `makeRandomString` is to create really long strings. In #10794, I used them to create nearly-unique unix paths for the daemon. Although collions are harmless and don't fail the tests, this prevents the same strings from being created consistently in every run by seeding rand.Random. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Contributor
|
LGTM |
Contributor
|
cool LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Feb 16, 2015
…domString integration-cli: Seed rand in makeRandomString
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current use of
makeRandomStringis to create reallylong strings. In #10794, I used them to create nearly-unique
unix paths for the daemon. Although collions are harmless and don't
fail the tests, this prevents the same strings from being created
consistently in every run by seeding a rand.Random instance.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @unclejack @jfrazelle