integration-cli: fix test to use busybox outside container #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMO, we should update this test to instead just We really shouldn't be embedding |
|
(or in any test, for that matter) |
|
Even slicker solution. Nice and simple; love it! ❤️ LGTM |
|
Changed test to just use |
Fixes TestRmiForceWithExistingContainers test to make it use `busybox` image rather than /docker-busybox hardcoded path and rebuilding image. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
LGTM 👍 |
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Feb 14, 2015
…hExistingContainers-fix integration-cli: fix test to use busybox outside container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TestRmiForceWithExistingContainers test to make it use
busyboximage rather than /docker-busybox hardcoded pathand rebuilding image.
TestRmiForceWithExistingContainersuses downloaded/docker-busyboxto build the image offline without networking.For cases where test needs to run outside docker containers(e.g. windows CI) it is okay for now to make network requests.
In that case, test now uses
busyboximage (or pull it first).This fixes the test without changing in-container behavior.Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @jfrazelle @duglin @unclejack @tianon @icecrime