New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-cli: pass platform-compatible paths to os.Symlink #10844

Merged
merged 1 commit into from Feb 21, 2015

Conversation

Projects
None yet
5 participants
@ahmetb
Contributor

ahmetb commented Feb 17, 2015

Although this doesn't fix the test (os.Symlink is not yet implemented for Windows), this prevents unix-style paths from being passed to os.Symlink. Also makes code cleaner for linux.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @tianon @unclejack @jfrazelle @icecrime

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 17, 2015

LGTM

@LK4D4

This comment has been minimized.

Contributor

LK4D4 commented Feb 20, 2015

@ahmetalpbalkan need rebase. Thanks!

integration-cli: pass platform-compatible paths to os.Symlink
Although this doesn't fix the test (os.Symlink is not yet
implemented for Windows), this prevents unix-style paths
from being passed to os.Symlink. Also makes code cleaner
for linux.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Feb 20, 2015

@LK4D4 rebased, thanks.

@LK4D4

This comment has been minimized.

Contributor

LK4D4 commented Feb 21, 2015

LGTM

LK4D4 added a commit that referenced this pull request Feb 21, 2015

Merge pull request #10844 from ahmetalpbalkan/win-cli/TestBuildDocker…
…fileOutsideContext-path-improvement

integration-cli: pass platform-compatible paths to os.Symlink

@LK4D4 LK4D4 merged commit 5919f1b into moby:master Feb 21, 2015

1 check passed

janky Jenkins build Docker-PRs 1523 has succeeded
Details

@ahmetb ahmetb deleted the ahmetb:win-cli/TestBuildDockerfileOutsideContext-path-improvement branch Feb 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment