Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -q argument in test using docker images -f #10868

Merged
merged 1 commit into from Feb 18, 2015
Merged

Use -q argument in test using docker images -f #10868

merged 1 commit into from Feb 18, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 18, 2015

The test case TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking
fails based on time because it uses full docker images output and
value in the CREATED column turns from A minute ago to 2 minutes ago
in the middle of execution and output comparison fails.

e.g.

REPOSITORY                                   TAG                 IMAGE ID            CREATED              VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        About a minute ago   2.433 MB

vs

REPOSITORY                                   TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        2 minutes ago       2.433 MB

This test doesn't really care about output cosmetics but rather image IDs returned
so -q makes sense here.

Signed-off-by: Ahmet Alp Balkan ahmetb@microsoft.com
cc: @jfrazelle @dkjer @unclejack @TintypeMolly @sachin-jayant-joshi

The test case `TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking`
fails based on time because it uses full `docker images` output and
value in the `CREATED` column turns from `A minute ago` to `2 minutes ago`
in the middle of execution and output comparison fails.

Signed-off-by: Ahmet Alp Balkan <ahmetb@microsoft.com>
@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 18, 2015

I personally think that that test mostly tests nothing, because it is not even care about image id :) But removing race is cool.
LGTM

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 18, 2015

hmmm ya what is this even testing.... but LGTM

jessfraz pushed a commit that referenced this issue Feb 18, 2015
…aceTrimmingAndLowerCasingWorking

Use `-q` argument in test using `docker images -f`
@jessfraz jessfraz merged commit 2f024bd into moby:master Feb 18, 2015
1 check passed
@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 18, 2015

Just rofl'd on the name of the test, I guess it must be testing if function-names with length > 80 chars are handled correctly 😄

@ahmetb ahmetb deleted the TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking branch Feb 18, 2015
@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Feb 18, 2015

Seems like this should be a filters unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants