New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use `-q` argument in test using `docker images -f` #10868

Merged
merged 1 commit into from Feb 18, 2015

Conversation

Projects
None yet
7 participants
@ahmetb
Contributor

ahmetb commented Feb 18, 2015

The test case TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking
fails based on time because it uses full docker images output and
value in the CREATED column turns from A minute ago to 2 minutes ago
in the middle of execution and output comparison fails.

e.g.

REPOSITORY                                   TAG                 IMAGE ID            CREATED              VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        About a minute ago   2.433 MB

vs

REPOSITORY                                   TAG                 IMAGE ID            CREATED             VIRTUAL SIZE
foo-1219                                     latest              2b7225e23d92        2 minutes ago       2.433 MB

This test doesn't really care about output cosmetics but rather image IDs returned
so -q makes sense here.

Signed-off-by: Ahmet Alp Balkan ahmetb@microsoft.com
cc: @jfrazelle @dkjer @unclejack @TintypeMolly @sachin-jayant-joshi

Use -q param in test using `docker images -f`
The test case `TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking`
fails based on time because it uses full `docker images` output and
value in the `CREATED` column turns from `A minute ago` to `2 minutes ago`
in the middle of execution and output comparison fails.

Signed-off-by: Ahmet Alp Balkan <ahmetb@microsoft.com>
@LK4D4

This comment has been minimized.

Contributor

LK4D4 commented Feb 18, 2015

I personally think that that test mostly tests nothing, because it is not even care about image id :) But removing race is cool.
LGTM

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 18, 2015

hmmm ya what is this even testing.... but LGTM

jessfraz pushed a commit that referenced this pull request Feb 18, 2015

Jessie Frazelle
Merge pull request #10868 from ahmetalpbalkan/TestImagesFilterWhiteSp…
…aceTrimmingAndLowerCasingWorking

Use `-q` argument in test using `docker images -f`

@jessfraz jessfraz merged commit 2f024bd into moby:master Feb 18, 2015

1 check passed

janky Jenkins build Docker-PRs 1279 has succeeded
Details
@thaJeztah

This comment has been minimized.

Member

thaJeztah commented Feb 18, 2015

Just rofl'd on the name of the test, I guess it must be testing if function-names with length > 80 chars are handled correctly 😄

@ahmetb ahmetb deleted the ahmetb:TestImagesFilterWhiteSpaceTrimmingAndLowerCasingWorking branch Feb 18, 2015

@cpuguy83

This comment has been minimized.

Contributor

cpuguy83 commented Feb 18, 2015

Seems like this should be a filters unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment