Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-cli: remove bash dependency from TestRunSetMacAddress #10870

Merged
merged 1 commit into from Feb 19, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 18, 2015

This change enables TestRunSetMacAddress to run on windows
without bash dependency. Also deferred call of cleanup
method.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com

@ahmetb ahmetb changed the title integration-cli: bash dependency from TestRunSetMacAddress integration-cli: remove bash dependency from TestRunSetMacAddress Feb 18, 2015
@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 18, 2015

https://jenkins.dockerproject.com/job/Windows-PRs/51/console
=== RUN TestRunSetMacAddress
[PASSED]: run - setting MAC address with --mac-address
--- PASS: TestRunSetMacAddress (1.30s) 👍

This change enables TestRunSetMacAddress to run on windows
without `bash` dependency. Also `defer`red call of cleanup
method.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 19, 2015

LGTM

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 19, 2015

ping @icecrime this one is small :D

@cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Feb 19, 2015

Phew that was a lot of shell in there...

LGTM

jessfraz pushed a commit that referenced this pull request Feb 19, 2015
…dress

integration-cli: remove bash dependency from TestRunSetMacAddress
@jessfraz jessfraz merged commit 6c3f089 into moby:master Feb 19, 2015
1 of 2 checks passed
1 of 2 checks passed
windows Jenkins build Windows-PRs 53 has failed
Details
janky Jenkins build Docker-PRs 1289 has succeeded
Details
@ahmetb ahmetb deleted the ahmetb:win-cli/TestRunSetMacAddress branch Feb 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.