integration-cli: remove bash dependency from TestRunSetMacAddress#10870
Merged
Conversation
ahmetb
changed the title
Contributor
Author
|
This change enables TestRunSetMacAddress to run on windows without `bash` dependency. Also `defer`red call of cleanup method. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
Contributor
|
LGTM |
Contributor
|
ping @icecrime this one is small :D |
Member
|
Phew that was a lot of shell in there... LGTM |
jessfraz
pushed a commit
that referenced
this pull request
Feb 19, 2015
…dress integration-cli: remove bash dependency from TestRunSetMacAddress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables
TestRunSetMacAddressto run on windowswithout
bashdependency. Alsodeferred call of cleanupmethod.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com