integration-cli: Fix path problems in TestBuildRenamedDockerfile #10873
Conversation
|
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| out, _, err = dockerCmdInDir(t, ctx.Dir, "build", fmt.Sprintf("--file=%s", dirWithNoDockerfile), "-t", "test5", ".") |
There was a problem hiding this comment.
This one is supposed to point to an existing file so I'm not sure this is the same testcase.
We may need to create a temp dir+file and then point to that?
There was a problem hiding this comment.
@duglin ah, makes sense. For some reason I guess I thought /etc/passwd as a dir. :-/ I'll fix this.
|
You may want to wait for #10555 to get merged first. |
|
@duglin makes sense. please get it merged :P |
|
@ahmetalpbalkan I'm twisting @tiborvass 's arm as hard as I can :-) |
|
ok that was merged you wanna update? |
`TestBuildRenamedDockerfile` tests hard-code unix-style path building. Made use of `path/filepath` to make these tests work on Windows as well. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
@jfrazelle rebased on top of master and pushed. |
|
Seems like all failed :) |
|
well its failing bc we need #10904 ;) |
|
LGTM |
|
ping @duglin |
|
|
Yup - LGTM |
…dDockerfile-fix integration-cli: Fix path problems in TestBuildRenamedDockerfile
TestBuildRenamedDockerfiletests hard-code unix-stylepath building. Made use of
path/filepathto make thesetests work on Windows as well.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @duglin @unclejack @jfrazelle @icecrime @tiborvass