Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
integration-cli: Better test cleanup with defer #10909
This fixes a few misuses of
Also added some forgotten cleanup calls while I'm at it.
changed the title from
Better test cleanup with defer
integration-cli: Better test cleanup with defer
Feb 20, 2015
@LK4D4 my pleasure. For deleteImages, we're doing a cleanup at the end and tests requiring an empty image list probably clean the env before they start. However we may care more about cleaning containers between test methods might be important as we sometimes use a hardcoded container name or port number. It'll increase execution time per test case.
Also the CI suite has a cleanup, so that serves the same purpose.
I'm now proposing a "webserver" image that shouldn't also be deleted like "busybox', in the meanwhile (#10893) so I am not really in for creating a deleteAllImagesExceptSome() route.