Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: fix volume test by passing unix path as volume #10911

Merged
merged 1 commit into from Feb 20, 2015
Merged

integ-cli: fix volume test by passing unix path as volume #10911

merged 1 commit into from Feb 20, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 20, 2015

This fixes TestVolumesNoCopyData for test execution on
windows by passing a unix-style path as volume even though
it's running on windows.

There's no point on creating that temp dir locally since we
could be running against a remote daemon that is not on this
test machine.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @jfrazelle @unclejack @duglin @icecrime (low-hanging fruit 馃崚)

This fixes `TestVolumesNoCopyData` for test execution on
windows by passing a unix-style path as volume even though
it's running on windows.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Feb 20, 2015

LGTM

@duglin
Copy link
Contributor

@duglin duglin commented Feb 20, 2015

Is it ok to remove the notion of asking the daemon to create that dir?

@duglin
Copy link
Contributor

@duglin duglin commented Feb 20, 2015

never mind - @cpuguy83 set me straight :-)
LGTM

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 20, 2015

Ok, seems legit :)
LGTM

LK4D4 added a commit that referenced this issue Feb 20, 2015
鈥yData-fix

integ-cli: fix volume test by passing unix path as volume
@LK4D4 LK4D4 merged commit b1509e8 into moby:master Feb 20, 2015
1 of 2 checks passed
@ahmetb ahmetb deleted the win-cli/TestVolumesNoCopyData-fix branch Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants