integ-cli: fix volume test by passing unix path as volume #10911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `TestVolumesNoCopyData` for test execution on windows by passing a unix-style path as volume even though it's running on windows. Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
|
LGTM |
|
Is it ok to remove the notion of asking the daemon to create that dir? |
|
never mind - @cpuguy83 set me straight :-) |
|
Ok, seems legit :) |
LK4D4
added a commit
that referenced
this pull request
Feb 20, 2015
…pyData-fix integ-cli: fix volume test by passing unix path as volume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
TestVolumesNoCopyDatafor test execution onwindows by passing a unix-style path as volume even though
it's running on windows.
There's no point on creating that temp dir locally since we
could be running against a remote daemon that is not on this
test machine.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @jfrazelle @unclejack @duglin @icecrime (low-hanging fruit 🍒)