Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add server OS/Arch info to 'version' cmd #10933

Merged
merged 1 commit into from Feb 23, 2015
Merged

cli: Add server OS/Arch info to 'version' cmd #10933

merged 1 commit into from Feb 23, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 22, 2015

Added 'OS/Arch (server)' line to docker version.

This info already is in /version endpoint but was missing from docker version output, it may come handy when we have a Windows daemon.

Client API version: 1.17
Go version (client): go1.4.1
OS/Arch (client): darwin/amd64
Server version: 1.5.0
Server API version: 1.17
Go version (server): go1.4.1
Git commit (server): a8a31ef
OS/Arch (server): linux/amd64 馃啎馃啎馃啎馃啎馃啎馃啎馃啎馃啎馃啎馃啎

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @vieux @jfrazelle @unclejack @tiborvass @tianon

@duglin
Copy link
Contributor

@duglin duglin commented Feb 22, 2015

LGTM

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 22, 2015

+1 useful if people run their client on a separate machine from the daemon.

@SvenDowideit
Copy link
Contributor

@SvenDowideit SvenDowideit commented Feb 23, 2015

+1! can you please add the same info to the info section in cli.md?

@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

@SvenDowideit there's not really much about docker version in cli.md what do you want me to add for instance?

@SvenDowideit
Copy link
Contributor

@SvenDowideit SvenDowideit commented Feb 23, 2015

@ahmetalpbalkan always +1 to more details :)

@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

@SvenDowideit added some stuff lmk if it looks good.

@SvenDowideit
Copy link
Contributor

@SvenDowideit SvenDowideit commented Feb 23, 2015

馃憤 - sorry, wrong part of the process for me to LGTM?

@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

does that count as LGTM? 馃槀

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 23, 2015

Guess it's a down-under "莎蕠苾l" 馃槉

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 23, 2015

@ahmetalpbalkan You should also add info to api docs and to whats new section.

@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

@LK4D4 that's not an API change? It's a very minor change and I'm not sure if it deserves a whatsnew entry. :)

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 23, 2015

@ahmetalpbalkan :) yeah, then api docs is wrong :/

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

@LK4D4 updated remote API docs as well.

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 23, 2015

Okay, at least it documented now :)
LGTM

@ahmetb
Copy link
Contributor Author

@ahmetb ahmetb commented Feb 23, 2015

@LK4D4 yeah, better late than never. 馃槇

@jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Feb 23, 2015

LGTM

1 similar comment
@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 23, 2015

LGTM

LK4D4 added a commit that referenced this issue Feb 23, 2015
cli: Add server OS/Arch info to 'version' cmd
@LK4D4 LK4D4 merged commit 02c8881 into moby:master Feb 23, 2015
1 check passed
@ahmetb ahmetb deleted the version-daemon-os-arch branch Feb 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants