New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: Skip new tests requiring same-host daemon #10995

Merged
merged 1 commit into from Feb 25, 2015

Conversation

Projects
None yet
5 participants
@ahmetb
Contributor

ahmetb commented Feb 24, 2015

This skips the following tests:

  • TestEventsFilters
  • TestExecAfterContainerRestart
  • TestRunExecDir
  • TestRunMutableNetworkFiles

as the tests require starting a daemon on the same host.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @unclejack @jfrazelle @LK4D4

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 24, 2015

sorry this was my fault LGTM

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 25, 2015

ok new idea if you want in TestEventsFilters we can remove:

events = events[:len(events)-1]
 if len(events) != 2 {
    t.Fatalf("Expected 2 events, got %d: %v", len(events), events)  
 }          

and instead iterate each line of events and make sure they are die, then we dont need a new daemon, up to you

@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Feb 25, 2015

@jfrazelle there's certain value in this test for the CLI. I'm okay waiting if you want to send a PR to fix the test. I can amend to skip only TestExecAfterContainerRestart in this commit.

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 25, 2015

fixed #10998

integ-cli: Skip new tests requiring same-host daemon
This skips tests:
- `TestExecAfterContainerRestart`

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Feb 25, 2015

amended commit.

@jessfraz

This comment has been minimized.

Contributor

jessfraz commented Feb 25, 2015

LGTM

1 similar comment
@cpuguy83

This comment has been minimized.

Contributor

cpuguy83 commented Feb 25, 2015

LGTM

jessfraz pushed a commit that referenced this pull request Feb 25, 2015

Jessie Frazelle
Merge pull request #10995 from ahmetalpbalkan/win-cli/SameHostDaemon-…
…skips-2

integ-cli: Skip new tests requiring same-host daemon

@jessfraz jessfraz merged commit 1060a53 into moby:master Feb 25, 2015

1 check was pending

janky Jenkins build Docker-PRs 1764 is running
Details

@jlhawn jlhawn removed the status/4-merge label Feb 25, 2015

@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Feb 25, 2015

ooh I was gonna skip more tests in the last minute, I guess I'll just open a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment