-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integ-cli: Skip new tests requiring same-host daemon #10995
Conversation
sorry this was my fault LGTM |
ok new idea if you want in
and instead iterate each line of events and make sure they are die, then we dont need a new daemon, up to you |
@jfrazelle there's certain value in this test for the CLI. I'm okay waiting if you want to send a PR to fix the test. I can amend to skip only TestExecAfterContainerRestart in this commit. |
fixed #10998 |
This skips tests: - `TestExecAfterContainerRestart` Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
amended commit. |
LGTM |
1 similar comment
LGTM |
…skips-2 integ-cli: Skip new tests requiring same-host daemon
ooh I was gonna skip more tests in the last minute, I guess I'll just open a new PR |
This skips the following tests:
TestEventsFilters
TestExecAfterContainerRestart
TestRunExecDir
TestRunMutableNetworkFiles
as the tests require starting a daemon on the same host.
Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @unclejack @jfrazelle @LK4D4