Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: skip TestRunBindMounts (same-host daemon requirement) #11004

Merged
merged 1 commit into from Feb 25, 2015
Merged

integ-cli: skip TestRunBindMounts (same-host daemon requirement) #11004

merged 1 commit into from Feb 25, 2015

Conversation

@ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Feb 25, 2015

TestRunBindMounts requires daemon to be on the same host
as it examines side effects of run -v... by running commands
on the filesystem of docker host.

Running this cli test on Linux is fair enough coverage for
this functionality and we can skip this for platforms where
daemon cannot run side-by-side with the cli for now.

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @cpuguy83 @duglin @jfrazelle @LK4D4

`TestRunBindMounts` requires daemon to be on the same host.
Running this cli test on Linux is fair enough coverage for
this functionality and we can skip this for platforms where
daemon cannot run side-by-side with the cli for now.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Feb 25, 2015

LGTM

@LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Feb 25, 2015

LGTM

LK4D4 added a commit that referenced this issue Feb 25, 2015
…ts-skip

integ-cli: skip TestRunBindMounts (same-host daemon requirement)
@LK4D4 LK4D4 merged commit 711175d into moby:master Feb 25, 2015
1 check passed
@ahmetb ahmetb deleted the win-cli/TestRunBindMounts-skip branch Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants