Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: skip case-sensitive dockerfile tests on windows #11186

Merged
merged 1 commit into from
Mar 6, 2015
Merged

integ-cli: skip case-sensitive dockerfile tests on windows #11186

merged 1 commit into from
Mar 6, 2015

Conversation

ahmetb
Copy link
Contributor

@ahmetb ahmetb commented Mar 5, 2015

The tests end up overwriting the dockerfile with Dockerfile since
windows filesystems are case-insensitive. The following methods are
skipped:

  • TestBuildRenamedDockerfile
  • TestBuildFromMixedcaseDockerfile

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @duglin

The tests end up overwriting the `dockerfile` with `Dockerfile` since
windows filesystems are case-insensitive. The following methods are
skipped:

- TestBuildRenamedDockerfile
- TestBuildFromMixedcaseDockerfile

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@duglin
Copy link
Contributor

duglin commented Mar 6, 2015

Assuming Jenkins is ok - LGTM

@ahmetb
Copy link
Contributor Author

ahmetb commented Mar 6, 2015

yeah

@tiborvass
Copy link
Contributor

LGTM

tiborvass added a commit that referenced this pull request Mar 6, 2015
…sensitive-fix

integ-cli: skip case-sensitive dockerfile tests on windows
@tiborvass tiborvass merged commit ecea4a9 into moby:master Mar 6, 2015
@ahmetb ahmetb deleted the win-cli/TestBuild-case-sensitive-fix branch March 6, 2015 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants