New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integ-cli: skip case-sensitive dockerfile tests on windows #11186

Merged
merged 1 commit into from Mar 6, 2015

Conversation

Projects
None yet
5 participants
@ahmetb
Contributor

ahmetb commented Mar 5, 2015

The tests end up overwriting the dockerfile with Dockerfile since
windows filesystems are case-insensitive. The following methods are
skipped:

  • TestBuildRenamedDockerfile
  • TestBuildFromMixedcaseDockerfile

Signed-off-by: Ahmet Alp Balkan ahmetalpbalkan@gmail.com
cc: @duglin

integ-cli: skip case-sensitive dockerfile tests on windows
The tests end up overwriting the `dockerfile` with `Dockerfile` since
windows filesystems are case-insensitive. The following methods are
skipped:

- TestBuildRenamedDockerfile
- TestBuildFromMixedcaseDockerfile

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
@duglin

This comment has been minimized.

Contributor

duglin commented Mar 6, 2015

Assuming Jenkins is ok - LGTM

@ahmetb

This comment has been minimized.

Contributor

ahmetb commented Mar 6, 2015

yeah

@tiborvass

This comment has been minimized.

Collaborator

tiborvass commented Mar 6, 2015

LGTM

tiborvass added a commit that referenced this pull request Mar 6, 2015

Merge pull request #11186 from ahmetalpbalkan/win-cli/TestBuild-case-…
…sensitive-fix

integ-cli: skip case-sensitive dockerfile tests on windows

@tiborvass tiborvass merged commit ecea4a9 into moby:master Mar 6, 2015

1 check passed

janky Jenkins build Docker-PRs 2580 has succeeded
Details

@ahmetb ahmetb deleted the ahmetb:win-cli/TestBuild-case-sensitive-fix branch Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment